mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-27 11:25:20 +00:00
jackandClaude Opus 5
ac13a0c22f
Raising four deadlines fixed the four tests that happened to fire. The class was still there: fourteen separate waitUntil helpers, most defaulting to 1.0s, plus wait call sites with literal budgets. The fifth instance would have landed the same way, on someone else's unrelated PR. The rule, now written down in TestConstants.settleTimeout: **a wait deadline is not a latency budget.** It exists so a genuine hang eventually fails the suite, so size it for the worst-case scheduler, never for how long the operation should take. Waits return as soon as their condition holds, so a generous deadline is free in the passing case and only extends genuine failures. - Every wait helper now defaults to TestConstants.settleTimeout (30s), and the literal wait call sites below the floor were converted too — sixteen sites across ten files. - TestTimingHygieneTests enforces it by scanning the test sources: wait defaults and wait call sites must be at least minimumSettleTimeout, and no test may assert an upper bound on elapsed wall-clock time (the assertion that started this, which cannot separate correct behaviour from a slow machine). - Both rules waive per line with "test-timing-ok: <reason>", accepted on the line or in the comment block above it so the reason has room to be a sentence. One legitimate use so far: a NEGATIVE wait in NoiseCoverageTests asserting a promotion has *not* completed within 50ms, where a long deadline would only make the suite slow while still passing. Injected production timeouts are deliberately not matched — the Noise handshake timeouts are the behaviour under test, and short values are correct there. Verified the guard actually fails: a canary file with both banned shapes was flagged with file and line, and the suite went green again once it was removed. Full suite passes with all 18 cores saturated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
114 lines
5.3 KiB
Swift
114 lines
5.3 KiB
Swift
import XCTest
|
|
import BitFoundation
|
|
@testable import bitchat
|
|
|
|
@MainActor
|
|
final class FavoritesPersistenceServiceTests: XCTestCase {
|
|
private let storageKey = "chat.bitchat.favorites"
|
|
private let serviceKey = "chat.bitchat.favorites"
|
|
|
|
func test_addFavorite_persistsAndPostsNotification() throws {
|
|
let keychain = MockKeychain()
|
|
let service = FavoritesPersistenceService(keychain: keychain)
|
|
let peerKey = Data((0..<32).map(UInt8.init))
|
|
let expectation = expectation(forNotification: .favoriteStatusChanged, object: nil)
|
|
|
|
service.addFavorite(peerNoisePublicKey: peerKey, peerNostrPublicKey: "npub1alice", peerNickname: "Alice")
|
|
|
|
wait(for: [expectation], timeout: TestConstants.settleTimeout)
|
|
XCTAssertTrue(service.isFavorite(peerKey))
|
|
XCTAssertEqual(service.getFavoriteStatus(for: peerKey)?.peerNickname, "Alice")
|
|
XCTAssertNotNil(keychain.load(key: storageKey, service: serviceKey))
|
|
}
|
|
|
|
func test_removeFavorite_preservesRelationshipWhenPeerStillFavoritesUs() {
|
|
let service = FavoritesPersistenceService(keychain: MockKeychain())
|
|
let peerKey = Data((32..<64).map(UInt8.init))
|
|
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: true, peerNickname: "Bob")
|
|
service.addFavorite(peerNoisePublicKey: peerKey, peerNickname: "Bob")
|
|
service.removeFavorite(peerNoisePublicKey: peerKey)
|
|
|
|
let relationship = service.getFavoriteStatus(for: peerKey)
|
|
XCTAssertNotNil(relationship)
|
|
XCTAssertEqual(relationship?.peerNickname, "Bob")
|
|
XCTAssertFalse(relationship?.isFavorite ?? true)
|
|
XCTAssertTrue(relationship?.theyFavoritedUs ?? false)
|
|
}
|
|
|
|
func test_updatePeerFavoritedUs_removesRelationshipWhenNeitherSideFavorites() {
|
|
let service = FavoritesPersistenceService(keychain: MockKeychain())
|
|
let peerKey = Data((64..<96).map(UInt8.init))
|
|
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: true, peerNickname: "Carol")
|
|
XCTAssertNotNil(service.getFavoriteStatus(for: peerKey))
|
|
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: false, peerNickname: "Carol")
|
|
|
|
XCTAssertNil(service.getFavoriteStatus(for: peerKey))
|
|
XCTAssertFalse(service.isMutualFavorite(peerKey))
|
|
}
|
|
|
|
func test_updatePeerFavoritedUs_keepsStoredNicknameOverUnknownPlaceholder() {
|
|
let service = FavoritesPersistenceService(keychain: MockKeychain())
|
|
let peerKey = Data((128..<160).map(UInt8.init))
|
|
|
|
service.addFavorite(peerNoisePublicKey: peerKey, peerNickname: "Erin")
|
|
|
|
// A notification arriving before the peer is known passes "Unknown".
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: true, peerNickname: "Unknown")
|
|
XCTAssertEqual(service.getFavoriteStatus(for: peerKey)?.peerNickname, "Erin")
|
|
|
|
// A real nickname still updates the stored one.
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: true, peerNickname: "Erin2")
|
|
XCTAssertEqual(service.getFavoriteStatus(for: peerKey)?.peerNickname, "Erin2")
|
|
}
|
|
|
|
func test_getFavoriteStatus_forPeerID_returnsMutualFavorite() {
|
|
let service = FavoritesPersistenceService(keychain: MockKeychain())
|
|
let peerKey = Data((96..<128).map(UInt8.init))
|
|
|
|
service.addFavorite(peerNoisePublicKey: peerKey, peerNostrPublicKey: "npub1dan", peerNickname: "Dan")
|
|
service.updatePeerFavoritedUs(peerNoisePublicKey: peerKey, favorited: true, peerNickname: "Dan")
|
|
|
|
let relationship = service.getFavoriteStatus(forPeerID: PeerID(publicKey: peerKey))
|
|
XCTAssertEqual(relationship?.peerNickname, "Dan")
|
|
XCTAssertTrue(service.isMutualFavorite(peerKey))
|
|
}
|
|
|
|
func test_init_deduplicatesPersistedRelationshipsByPublicKey() throws {
|
|
let keychain = MockKeychain()
|
|
let peerKey = Data((128..<160).map(UInt8.init))
|
|
let older = FavoritesPersistenceService.FavoriteRelationship(
|
|
peerNoisePublicKey: peerKey,
|
|
peerNostrPublicKey: nil,
|
|
peerNickname: "Older",
|
|
isFavorite: true,
|
|
theyFavoritedUs: false,
|
|
favoritedAt: Date(timeIntervalSince1970: 100),
|
|
lastUpdated: Date(timeIntervalSince1970: 100)
|
|
)
|
|
let newer = FavoritesPersistenceService.FavoriteRelationship(
|
|
peerNoisePublicKey: peerKey,
|
|
peerNostrPublicKey: "npub1newer",
|
|
peerNickname: "Newer",
|
|
isFavorite: true,
|
|
theyFavoritedUs: true,
|
|
favoritedAt: Date(timeIntervalSince1970: 100),
|
|
lastUpdated: Date(timeIntervalSince1970: 200)
|
|
)
|
|
let encoded = try JSONEncoder().encode([older, newer])
|
|
keychain.save(key: storageKey, data: encoded, service: serviceKey, accessible: nil)
|
|
|
|
let service = FavoritesPersistenceService(keychain: keychain)
|
|
|
|
XCTAssertEqual(service.favorites.count, 1)
|
|
XCTAssertEqual(service.getFavoriteStatus(for: peerKey)?.peerNickname, "Newer")
|
|
XCTAssertEqual(service.getFavoriteStatus(for: peerKey)?.peerNostrPublicKey, "npub1newer")
|
|
|
|
let cleaned = try XCTUnwrap(keychain.load(key: storageKey, service: serviceKey))
|
|
let decoded = try JSONDecoder().decode([FavoritesPersistenceService.FavoriteRelationship].self, from: cleaned)
|
|
XCTAssertEqual(decoded.count, 1)
|
|
}
|
|
}
|