mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-26 20:25:22 +00:00
jackandClaude Opus 5
862e44e2e1
Tier 3 of a protest-hardening review. The BLE mesh is already properly fenced off from network reachability and needs nothing here; every gap is on the internet side, or in how someone gets a build they can trust. Say when Tor is blocked. The bootstrap poll loop simply ended at its 75-second deadline, leaving isStarting true with no further state, so a network that blocks Tor was indistinguishable from a slow one and the UI said "starting tor…" indefinitely. TorManager now exposes bootstrapDidStall and posts .TorBootstrapDidStall, and the app reports that mesh messaging still works while internet delivery is paused. It is cleared on each new start or restart, so a later attempt can report again. Let relays be added by hand. The four built-in relays are well-known clearnet hostnames, which is four names for a censor to block and no recourse short of a new build. NostrRelaySettings persists up to eight additional relays, normalized, .onion accepted, with a settings editor. They join the same target set as the built-ins and are subject to the same activation policy. Removal reconciles against the previous set: the teardown path iterates the current targets, so without that a removed relay's socket and queued sends would linger — covered by a test that fails without it. The merged list is cached rather than recomputed, because allowedRelayList consults it once per candidate URL and would otherwise read UserDefaults inside that loop. Stop stranding people who denied location. The activation gate required location permission or a mutual favorite, but teleporting into a geohash requires neither, so someone with no permission and no favorites could sit in a channel that never connected while Tor and the relays stayed suppressed and nothing said why. Being in a location channel is now a third arm of the gate, in both the activation service and the relay manager's copy of the policy, and leaving the channel closes it again. Stop burning the Tor timeout when Tor is off. GeoRelayDirectory awaited Tor readiness unconditionally, but with the preference off TorManager has been shut down, so every refresh spent the full bootstrap deadline and the directory froze on its cached copy. It now keys on the preference, not on live readiness: Tor wanted but unavailable must still skip the fetch rather than fall back to clearnet. Say what turning Tor off costs. The toggle's copy described it as hiding your IP "for location channels", understating both scope and consequence. It now names private messages too, and while the toggle is off the settings screen states that every relay can see the device IP. Make builds verifiable. There was no release verification of any kind: no signatures, no checksums, no documented procedure. Post-takedown that is the acute gap, because mirrors appear and people install whatever they can find during a shutdown. source-manifest.yml publishes a per-tag SHA-256 manifest with a provenance attestation, self-checking before it publishes, and docs/VERIFYING-A-BUILD.md explains how to verify source and states plainly that compiled builds from anywhere but the App Store cannot be verified. It also records the gaps honestly: no published signing key, no reproducible build, no non-GitHub mirror. docs/TOR-INTEGRATION.md was substantially stale — it documented a torrc, SOCKSPort and ControlPort that the in-process Arti client does not use, and claimed there are no user-visible settings — so it is rewritten, including the deferred gap below. Deferred: no Tor bridges or pluggable transports. arti-client is built without pt-client or bridge-client and bootstraps from stock config, so in a country that blocks Tor outright there is still no circumvention path — only a clear report that there isn't. Closing it needs the Rust features, bridge config through the FFI, and an xcframework rebuild under the pinned toolchain with a provenance update, which is its own change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
39 lines
1.5 KiB
Swift
39 lines
1.5 KiB
Swift
import Foundation
|
|
import Testing
|
|
@testable import bitchat
|
|
|
|
/// The geo-relay directory refresh runs off the main actor and has to decide
|
|
/// whether waiting for Tor is meaningful. It previously waited unconditionally,
|
|
/// so with Tor switched off — and `TorManager` therefore shut down — every
|
|
/// refresh spent the full bootstrap timeout and the directory froze on its
|
|
/// cached copy.
|
|
struct TorPreferenceReadTests {
|
|
private func makeDefaults() -> UserDefaults {
|
|
UserDefaults(suiteName: "bitchat.tests.tor.\(UUID().uuidString)")!
|
|
}
|
|
|
|
@Test func defaultsToOnWhenNothingHasBeenStored() {
|
|
// Fail safe: an unwritten preference must not read as "Tor off", which
|
|
// would let a fetch go direct.
|
|
#expect(NetworkActivationService.persistedTorPreference(in: makeDefaults()))
|
|
}
|
|
|
|
@Test func reflectsTheStoredPreference() {
|
|
let defaults = makeDefaults()
|
|
|
|
defaults.set(false, forKey: NetworkActivationService.torPreferenceKey)
|
|
#expect(!NetworkActivationService.persistedTorPreference(in: defaults))
|
|
|
|
defaults.set(true, forKey: NetworkActivationService.torPreferenceKey)
|
|
#expect(NetworkActivationService.persistedTorPreference(in: defaults))
|
|
}
|
|
|
|
@Test func nonBooleanStoredValueReadsAsOn() {
|
|
let defaults = makeDefaults()
|
|
defaults.set("nonsense", forKey: NetworkActivationService.torPreferenceKey)
|
|
|
|
// Same fail-safe direction: anything unrecognized means keep using Tor.
|
|
#expect(NetworkActivationService.persistedTorPreference(in: defaults))
|
|
}
|
|
}
|