Files
bitchat/bitchatTests/ChatViewModelTests.swift
T
806c420313 Add comprehensive test coverage for ChatViewModel and BLEService (#962)
* Add comprehensive test coverage for ChatViewModel and BLEService

This commit adds 14 new tests to improve the safety net for future
refactoring of ChatViewModel and BLEService:

New test files:
- ChatViewModelTorTests: Tor lifecycle notification handlers (8 tests)
- ChatViewModelDeliveryStatusTests: Delivery status state machine (6 tests)
- ChatViewModelRefactoringTests: Command routing and message handling (4 tests)
- BLEServiceCoreTests: Packet deduplication and stale broadcast filtering (2 tests)
- PublicMessagePipelineTests: Message ordering and deduplication (4 tests)
- MessageRouterTests: Transport selection and outbox behavior (4 tests)
- PrivateChatManagerTests: Chat selection and read receipts (2 tests)
- UnifiedPeerServiceTests: Fingerprint resolution and blocking (2 tests)
- RelayControllerTests: TTL, handshake, and fragment relay logic (4 tests)

Modified files:
- MockTransport: Added peer snapshot publishing on connect/disconnect
- TestHelpers: Added waitUntil polling helper for async tests
- MockIdentityManager: Extended for new test scenarios

Total: 454 tests across 64 suites (was 440)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Fix flaky test by using waitUntil instead of fixed sleep

Replace fixed 200ms sleep with waitUntil helper for more reliable
async assertion in routing tests. This prevents timing issues on CI.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: jack <jackjackbits@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-16 16:02:13 -10:00

517 lines
15 KiB
Swift

//
// ChatViewModelTests.swift
// bitchatTests
//
// Tests for ChatViewModel using MockTransport for isolation.
// This is free and unencumbered software released into the public domain.
//
import Testing
import Foundation
@testable import bitchat
// MARK: - Test Helpers
/// Creates a ChatViewModel with mock dependencies for testing
@MainActor
private func makeTestableViewModel() -> (viewModel: ChatViewModel, transport: MockTransport) {
let keychain = MockKeychain()
let keychainHelper = MockKeychainHelper()
let idBridge = NostrIdentityBridge(keychain: keychainHelper)
let identityManager = MockIdentityManager(keychain)
let transport = MockTransport()
let viewModel = ChatViewModel(
keychain: keychain,
idBridge: idBridge,
identityManager: identityManager,
transport: transport
)
return (viewModel, transport)
}
// MARK: - Initialization Tests
struct ChatViewModelInitializationTests {
@Test @MainActor
func initialization_setsDelegate() async {
let (viewModel, transport) = makeTestableViewModel()
// The viewModel should set itself as the transport delegate
#expect(transport.delegate === viewModel)
}
@Test @MainActor
func initialization_startsServices() async {
let (_, transport) = makeTestableViewModel()
// Services should be started during init
#expect(transport.startServicesCallCount == 1)
}
@Test @MainActor
func initialization_hasEmptyMessageList() async {
let (viewModel, _) = makeTestableViewModel()
// Initial messages may include system messages, but should be limited
#expect(viewModel.messages.count < 10)
}
@Test @MainActor
func initialization_setsNickname() async {
let (_, transport) = makeTestableViewModel()
// Nickname should be set during init
#expect(!transport.myNickname.isEmpty)
}
}
// MARK: - Message Sending Tests
struct ChatViewModelSendingTests {
@Test @MainActor
func sendMessage_delegatesToTransport() async {
let (viewModel, transport) = makeTestableViewModel()
viewModel.sendMessage("Hello World")
#expect(transport.sentMessages.count == 1)
#expect(transport.sentMessages.first?.content == "Hello World")
}
@Test @MainActor
func sendMessage_emptyContent_ignored() async {
let (viewModel, transport) = makeTestableViewModel()
viewModel.sendMessage("")
viewModel.sendMessage(" ")
viewModel.sendMessage("\n\t")
#expect(transport.sentMessages.isEmpty)
}
@Test @MainActor
func sendMessage_withMentions_sendsContent() async {
let (viewModel, transport) = makeTestableViewModel()
viewModel.sendMessage("Hello @alice")
#expect(transport.sentMessages.count == 1)
#expect(transport.sentMessages.first?.content == "Hello @alice")
}
@Test @MainActor
func sendMessage_command_notSentToTransport() async {
let (viewModel, transport) = makeTestableViewModel()
viewModel.sendMessage("/help")
// Commands are processed locally, not sent to transport
#expect(transport.sentMessages.isEmpty)
}
}
// MARK: - Command Handling Tests
struct ChatViewModelCommandTests {
@Test @MainActor
func sendMessage_commandsNotSentToTransport() async {
let (viewModel, transport) = makeTestableViewModel()
let commands = ["/nick bob", "/who", "/help", "/clear"]
for command in commands {
transport.resetRecordings()
viewModel.sendMessage(command)
try? await Task.sleep(nanoseconds: 100_000_000)
#expect(transport.sentMessages.isEmpty)
#expect(transport.sentPrivateMessages.isEmpty)
}
}
}
// MARK: - Timeline Cap Tests
struct ChatViewModelTimelineCapTests {
@Test @MainActor
func sendMessage_trimsTimelineToCap() async {
let (viewModel, _) = makeTestableViewModel()
let total = TransportConfig.meshTimelineCap + 5
for i in 0..<total {
viewModel.sendMessage("cap-msg-\(i)")
}
#expect(viewModel.messages.count == TransportConfig.meshTimelineCap)
#expect(viewModel.messages.last?.content == "cap-msg-\(total - 1)")
}
}
// MARK: - Message Receiving Tests
struct ChatViewModelReceivingTests {
@Test @MainActor
func didReceiveMessage_callsDelegate() async {
let (_, transport) = makeTestableViewModel()
let message = BitchatMessage(
id: "msg-001",
sender: "Alice",
content: "Hello from Alice",
timestamp: Date(),
isRelay: false,
originalSender: nil,
isPrivate: false,
recipientNickname: nil,
senderPeerID: PeerID(str: "PEER001"),
mentions: nil
)
transport.simulateIncomingMessage(message)
// Give time for Task and pipeline processing
try? await Task.sleep(nanoseconds: 200_000_000)
// Message may or may not appear due to rate limiting/pipeline batching
// The important thing is no crash and delegate was called
#expect(transport.delegate != nil)
}
@Test @MainActor
func didReceivePublicMessage_addsToTimeline() async {
let (viewModel, transport) = makeTestableViewModel()
transport.simulateIncomingPublicMessage(
from: PeerID(str: "PEER002"),
nickname: "Bob",
content: "Public hello from Bob",
timestamp: Date(),
messageID: "pub-001"
)
// Give time for async Task and pipeline processing
try? await Task.sleep(nanoseconds: 500_000_000)
#expect(viewModel.messages.contains { $0.content == "Public hello from Bob" })
}
}
// MARK: - Rate Limiting Tests
struct ChatViewModelRateLimitingTests {
@Test @MainActor
func handlePublicMessage_rateLimitsBurstBySender() async {
let (viewModel, _) = makeTestableViewModel()
let senderID = PeerID(str: "1122334455667788")
let now = Date()
for i in 0..<6 {
let message = BitchatMessage(
id: "rate-\(i)",
sender: "Spammer",
content: "rate-msg-\(i)",
timestamp: now,
isRelay: false,
originalSender: nil,
isPrivate: false,
recipientNickname: nil,
senderPeerID: senderID,
mentions: nil
)
viewModel.handlePublicMessage(message)
}
viewModel.publicMessagePipeline.flushIfNeeded()
let burstMessages = viewModel.messages.filter { $0.content.hasPrefix("rate-msg-") }
#expect(burstMessages.count == 5)
#expect(!burstMessages.contains { $0.content == "rate-msg-5" })
}
}
// MARK: - Peer Connection Tests
struct ChatViewModelPeerTests {
@Test @MainActor
func didConnectToPeer_notifiesDelegate() async {
let (_, transport) = makeTestableViewModel()
let peerID = PeerID(str: "NEWPEER")
transport.simulateConnect(peerID, nickname: "NewUser")
#expect(transport.connectedPeers.contains(peerID))
}
@Test @MainActor
func didDisconnectFromPeer_notifiesDelegate() async {
let (_, transport) = makeTestableViewModel()
let peerID = PeerID(str: "OLDPEER")
transport.simulateConnect(peerID, nickname: "OldUser")
transport.simulateDisconnect(peerID)
#expect(!transport.connectedPeers.contains(peerID))
}
@Test @MainActor
func isPeerConnected_delegatesToTransport() async {
let (_, transport) = makeTestableViewModel()
let peerID = PeerID(str: "TESTPEER")
// Not connected initially
#expect(!transport.isPeerConnected(peerID))
transport.connectedPeers.insert(peerID)
#expect(transport.isPeerConnected(peerID))
}
}
// MARK: - Deduplication Integration Tests
//
// Note: Detailed deduplication logic is tested in MessageDeduplicationServiceTests.
// These tests verify that ChatViewModel has a deduplication service configured.
struct ChatViewModelDeduplicationTests {
@Test @MainActor
func deduplicationService_isConfigured() async {
let (viewModel, _) = makeTestableViewModel()
// Verify the deduplication service is available and functional
// by checking that we can record and query content
let testContent = "Test dedup content \(UUID().uuidString)"
let testDate = Date()
viewModel.deduplicationService.recordContent(testContent, timestamp: testDate)
let retrieved = viewModel.deduplicationService.contentTimestamp(for: testContent)
#expect(retrieved == testDate)
}
@Test @MainActor
func deduplicationService_normalizedKey_consistent() async {
let (viewModel, _) = makeTestableViewModel()
let content = "Hello World"
let key1 = viewModel.deduplicationService.normalizedContentKey(content)
let key2 = viewModel.deduplicationService.normalizedContentKey(content)
#expect(key1 == key2)
}
}
// MARK: - Private Chat Tests
struct ChatViewModelPrivateChatTests {
@Test @MainActor
func sendPrivateMessage_delegatesToTransport() async {
let (viewModel, transport) = makeTestableViewModel()
let recipientID = PeerID(str: "RECIPIENT")
// Set up connected peer for routing
transport.connectedPeers.insert(recipientID)
transport.peerNicknames[recipientID] = "Recipient"
viewModel.sendPrivateMessage("Secret message", to: recipientID)
// The message routing depends on connection state and other factors
// At minimum, it should not crash
#expect(true) // If we get here without crash, the test passes
}
}
// MARK: - Private Chat Selection Tests
struct ChatViewModelPrivateChatSelectionTests {
@Test @MainActor
func openMostRelevantPrivateChat_prefersUnreadMostRecent() async {
let (viewModel, _) = makeTestableViewModel()
let peerA = PeerID(str: "PEER_A")
let peerB = PeerID(str: "PEER_B")
let older = Date().addingTimeInterval(-120)
let newer = Date().addingTimeInterval(-30)
viewModel.privateChats = [
peerA: [
BitchatMessage(
id: "a-1",
sender: "A",
content: "Old",
timestamp: older,
isRelay: false,
isPrivate: true,
recipientNickname: "Me",
senderPeerID: peerA
)
],
peerB: [
BitchatMessage(
id: "b-1",
sender: "B",
content: "New",
timestamp: newer,
isRelay: false,
isPrivate: true,
recipientNickname: "Me",
senderPeerID: peerB
)
]
]
viewModel.unreadPrivateMessages = [peerA, peerB]
viewModel.openMostRelevantPrivateChat()
#expect(viewModel.selectedPrivateChatPeer == peerB)
}
@Test @MainActor
func openMostRelevantPrivateChat_fallsBackToMostRecentChat() async {
let (viewModel, _) = makeTestableViewModel()
let peerA = PeerID(str: "PEER_A")
let peerB = PeerID(str: "PEER_B")
let older = Date().addingTimeInterval(-200)
let newer = Date().addingTimeInterval(-20)
viewModel.privateChats = [
peerA: [
BitchatMessage(
id: "a-1",
sender: "A",
content: "Old",
timestamp: older,
isRelay: false,
isPrivate: true,
recipientNickname: "Me",
senderPeerID: peerA
)
],
peerB: [
BitchatMessage(
id: "b-1",
sender: "B",
content: "New",
timestamp: newer,
isRelay: false,
isPrivate: true,
recipientNickname: "Me",
senderPeerID: peerB
)
]
]
viewModel.openMostRelevantPrivateChat()
#expect(viewModel.selectedPrivateChatPeer == peerB)
}
}
// MARK: - Bluetooth State Tests
struct ChatViewModelBluetoothTests {
@Test @MainActor
func didUpdateBluetoothState_poweredOn_noAlert() async {
let (viewModel, transport) = makeTestableViewModel()
transport.simulateBluetoothStateChange(.poweredOn)
// Give time for async processing
try? await Task.sleep(nanoseconds: 100_000_000)
#expect(!viewModel.showBluetoothAlert)
}
@Test @MainActor
func didUpdateBluetoothState_poweredOff_showsAlert() async {
let (viewModel, transport) = makeTestableViewModel()
transport.simulateBluetoothStateChange(.poweredOff)
// Give time for async processing
try? await Task.sleep(nanoseconds: 100_000_000)
#expect(viewModel.showBluetoothAlert)
}
@Test @MainActor
func didUpdateBluetoothState_unauthorized_showsAlert() async {
let (viewModel, transport) = makeTestableViewModel()
transport.simulateBluetoothStateChange(.unauthorized)
// Give time for async processing
try? await Task.sleep(nanoseconds: 100_000_000)
#expect(viewModel.showBluetoothAlert)
}
}
// MARK: - Panic Clear Tests
struct ChatViewModelPanicTests {
@Test @MainActor
func panicClearAllData_delegatesToTransport() async {
let (viewModel, transport) = makeTestableViewModel()
// Set up some state
transport.connectedPeers.insert(PeerID(str: "PEER1"))
viewModel.messages = [
BitchatMessage(
id: "panic-1",
sender: "Tester",
content: "Before",
timestamp: Date(),
isRelay: false
)
]
viewModel.privateChats[PeerID(str: "PEER1")] = [
BitchatMessage(
id: "pm-1",
sender: "Peer",
content: "Secret",
timestamp: Date(),
isRelay: false,
isPrivate: true,
recipientNickname: "Me",
senderPeerID: PeerID(str: "PEER1")
)
]
viewModel.unreadPrivateMessages.insert(PeerID(str: "PEER1"))
viewModel.panicClearAllData()
// After panic, emergency disconnect should be called
#expect(transport.emergencyDisconnectCallCount == 1)
#expect(viewModel.messages.isEmpty)
#expect(viewModel.privateChats.isEmpty)
#expect(viewModel.unreadPrivateMessages.isEmpty)
#expect(viewModel.selectedPrivateChatPeer == nil)
}
}
// MARK: - Service Lifecycle Tests
struct ChatViewModelLifecycleTests {
@Test @MainActor
func startServices_calledOnInit() async {
let (_, transport) = makeTestableViewModel()
#expect(transport.startServicesCallCount == 1)
}
}