2 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
3 people	e96330e50b	Migrate from LiveData to Kotlin Flow (#518) ... * Automated update of relay data - Sun Sep 21 06:21:05 UTC 2025 * Automated update of relay data - Sun Sep 28 06:20:40 UTC 2025 * refactor: new close button like ios(but not liquid glass) * Automated update of relay data - Sun Oct 5 06:20:09 UTC 2025 * Automated update of relay data - Sun Oct 12 06:20:12 UTC 2025 * Automated update of relay data - Sun Oct 19 06:21:51 UTC 2025 * Automated update of relay data - Sun Oct 26 06:21:31 UTC 2025 * Automated update of relay data - Sun Nov 2 06:22:16 UTC 2025 * Automated update of relay data - Sun Nov 9 06:21:43 UTC 2025 * Automated update of relay data - Sun Nov 16 06:22:37 UTC 2025 * Automated update of relay data - Sun Nov 23 06:22:51 UTC 2025 * Automated update of relay data - Sun Nov 30 06:24:08 UTC 2025 * Chore: Remove unused `lifecycle-livedata-ktx` dependency This commit removes the `androidx.lifecycle:lifecycle-livedata-ktx` library from the project's dependencies. The `[libraries]` and `[bundles]` sections in `gradle/libs.versions.toml` have been updated to reflect this removal, as the dependency is no longer in use. * Refactor: Remove unused `runtime-livedata` dependency * Refactor: Migrate `LocationChannelManager` and `GeohashBookmarksStore` to StateFlow This commit refactors `LocationChannelManager` and `GeohashBookmarksStore` to use `StateFlow` instead of `LiveData` for managing and exposing their state. This change aligns with modern Android development practices and improves testability. **Key Changes:** - **`LocationChannelManager`**: - All `MutableLiveData` properties (`permissionState`, `availableChannels`, `selectedChannel`, etc.) have been replaced with `MutableStateFlow`. - Consumers now access these properties as `StateFlow`. - State updates have been changed from `postValue()` to direct `.value` assignments, simplifying thread management within the manager which already uses a dedicated coroutine scope. - **`GeohashBookmarksStore`**: - `bookmarks` and `bookmarkNames` are now exposed as `StateFlow` instead of `LiveData`. - State updates similarly use `.value` assignment. - **Nullability**: - The non-nullable nature of `StateFlow`'s value reduces the need for null-checks in both the manager classes and their consumers, leading to safer code. * Refactor: Migrate from LiveData to StateFlow for Nostr components This commit replaces `LiveData` with `StateFlow` across core Nostr-related classes to align with modern Android architecture and improve state management. This change affects `NostrClient`, `NostrRelayManager`, `LocationNotesManager`, and `GeohashRepository`. **Key Changes:** - **`NostrClient`**: - `isInitialized` and `currentNpub` are now `StateFlow` instead of `LiveData`. - `relayConnectionStatus` and `relayInfo` now return `StateFlow` from `NostrRelayManager`. - **`NostrRelayManager`**: - Public properties `relays` and `isConnected` are migrated from `MutableLiveData` to `MutableStateFlow`. - Updates are now pushed using `.value` instead of `.postValue()`. - **`LocationNotesManager`**: - All public `LiveData` properties (`notes`, `geohash`, `initialLoadComplete`, `state`, `errorMessage`) are converted to `StateFlow`. - The class documentation is updated to reflect the use of `StateFlow`. - **`GeohashRepository`**: - Methods `updateGeohashPeople` and `updateReactiveParticipantCounts` now call `set...` methods on the `state` object instead of `post...`, reflecting the removal of `LiveData` from the underlying state management. * Refactor: Migrate ChatState from LiveData to StateFlow This commit refactors the `ChatState`, `ChatViewModel`, and `GeohashViewModel` to use `StateFlow` instead of `LiveData` for managing and exposing UI state. This migration improves state management by leveraging modern coroutine-based flows. **Key Changes:** - **`ChatState.kt`**: - Replaced all `MutableLiveData` instances with `MutableStateFlow`. - Exposed state properties as `StateFlow` instead of `LiveData`. - Removed `MediatorLiveData` for computed properties (`hasUnreadChannels`, `hasUnreadPrivateMessages`) and replaced them with `Flow.combine` to create derivative `StateFlows`. - Simplified non-nullable `getters` to directly return the `.value` of the `StateFlows`. - Removed `postValue` helpers that are no longer necessary. - **`ChatViewModel.kt`**: - Updated all state properties to be `StateFlow`, reflecting the changes in `ChatState`. - **`GeohashViewModel.kt`**: - Changed state properties (`geohashPeople`, `geohashParticipantCounts`, etc.) from `LiveData` to `StateFlow`. - Replaced `observeForever` on `LiveData` from `LocationChannelManager` with `viewModelScope.launch` blocks that `.collect()` from the underlying flows. * Refactor: Migrate UI from LiveData to StateFlow This commit replaces `LiveData.observeAsState()` with `StateFlow.collectAsState()` across various UI components. This change aligns the codebase with modern Android development practices, using Kotlin Flows for reactive UI state management. No functional changes are intended. The primary goal is to remove the dependency on `androidx.lifecycle.livedata` from the composable functions. **Affected Components:** - `ChatScreen` - `SidebarComponents` - `ChatHeader` - `LocationChannelsSheet` - `LocationNotesSheet` - `LocationNotesButton` - `GeohashPeopleList` - `LocationNotesSheetPresenter` * Refactor: Use `collectAsStateWithLifecycle` for UI state collection * Refactor: move CloseButton to core/ui/component * Refactor: remove AI generated comments * Refactor: fix combine to map and use WhileSubscribed * Refactor: Pass CoroutineScope to ChatState This commit refactors the `ChatState` class to accept a `CoroutineScope` in its constructor instead of creating its own. **Key Changes:** - **`ChatState.kt`**: The constructor now requires a `CoroutineScope`. This scope is used for the `stateIn` operators that convert `Flows` into `StateFlows` (`hasUnreadChannels`, `hasUnreadPrivateMessages`), ensuring they operate within the lifecycle of the provided scope. - **`ChatViewModel.kt`**: The `viewModelScope` is now passed to the `ChatState` constructor during its instantiation. This ties the lifecycle of the state's coroutines directly to the `ViewModel`'s lifecycle. * Test: Use `TestScope` for coroutines in `CommandProcessorTest` This commit refactors `CommandProcessorTest` to use a `TestScope` and `UnconfinedTestDispatcher` for managing coroutines. This ensures that coroutine-based operations within the test are executed in a controlled and predictable manner, improving test reliability. The `coroutineScope` for `CommandProcessor` and the `scope` for `ChatState` are now both configured to use this test-specific scope. --------- Co-authored-by: GitHub Action <action@github.com>	2025-12-13 15:58:48 +07:00
3 people	eba0d36015	Add App Info Bottom Sheet (#406) ... * Automated update of relay data - Sun Sep 7 06:20:11 UTC 2025 * Refactor(ui): Improve AboutSheet design and layout Ios Like This commit refactors the `AboutSheet` composable with several UI enhancements: - Updated the overall layout and styling for a more modern look and feel. - Introduced a collapsing top bar effect on scroll. - Replaced `FeatureCard` with individual `Row` layouts for feature descriptions. - Adjusted typography, spacing, and padding for better readability. - Updated color usage to align with `MaterialTheme.colorScheme`. - Made the bottom sheet skip the partially expanded state by default. - Added `statusBarsPadding` to the `ModalBottomSheet`. --------- Co-authored-by: GitHub Action <action@github.com>	2025-09-14 03:37:53 +02:00