Files
bitchat/bitchatTests/Mocks/MockTransport.swift
T
ef848857b7 Remove dead code found by full Periphery audit; add scan config + advisory CI (#1410)
Periphery 3.7.4 audit of both schemes (macOS + iOS, intersected so
platform-specific code is never touched), with test targets indexed and
the share extension built. 277 dead declarations removed or demoted:
dead forwarding wrappers (ChatViewModel+Nostr/+PrivateChat), removed-
feature remnants (autocomplete command suggestions, back-swipe tuning,
MediaSendError, GeohashParticipantTracker), unused Tor dormancy
bindings, assign-only properties, unused parameters (renamed to _), and
redundant public accessibility. 13 orphaned localization keys deleted
across all 29 locales (old pre-#1392 location-notes UI, app_info
warnings).

Two real tests were flagged as unused because they never ran: Swift
Testing methods missing @Test (NostrProtocolTests.
testAckRoundTripNIP44V2_Delivered, NotificationStreamAssemblerTests.
testAssemblesCompressedLargeFrame). Re-armed both; they pass.

Deliberately kept, now recorded in .periphery.baseline.json: iOS-only
code invisible to the CI macOS scan, C FFI signatures, keep-alive
NWPathMonitor reference, InboundEventKey.eventID (dedup semantics),
wifiBulk capability bit (reserved for Wi-Fi bulk work, used by
BitFoundation package tests), and the String secureClear cluster
(exercised by package tests).

New: .periphery.yml config and an advisory Dead Code CI job (mirrors
the SwiftLint precedent from #1361) that fails on findings not in the
committed baseline.

Verified: full macOS app suite, BitFoundation (119) and BitLogger (13)
package tests green; periphery scan --strict exits clean.

Co-authored-by: jack <jackjackbits@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 11:24:19 +02:00

307 lines
10 KiB
Swift

//
// MockTransport.swift
// bitchatTests
//
// Mock Transport implementation for unit testing ChatViewModel.
// This is free and unencumbered software released into the public domain.
//
import Foundation
import Combine
import CoreBluetooth
import BitFoundation
@testable import bitchat
/// Mock Transport implementation for testing ChatViewModel in isolation.
/// Records all method calls and allows test code to verify interactions.
final class MockTransport: Transport {
// MARK: - Protocol Properties
weak var delegate: BitchatDelegate?
weak var eventDelegate: TransportEventDelegate?
weak var peerEventsDelegate: TransportPeerEventsDelegate?
var myPeerID: PeerID = PeerID(str: "TESTPEER")
var myNickname: String = "TestUser"
private let peerSnapshotSubject = CurrentValueSubject<[TransportPeerSnapshot], Never>([])
// MARK: - Recording Properties (for test assertions)
private(set) var sentMessages: [(content: String, mentions: [String], messageID: String?, timestamp: Date?)] = []
private(set) var sentPrivateMessages: [(content: String, peerID: PeerID, recipientNickname: String, messageID: String)] = []
private(set) var sentReadReceipts: [(receipt: ReadReceipt, peerID: PeerID)] = []
private(set) var sentDeliveryAcks: [(messageID: String, peerID: PeerID)] = []
private(set) var sentFavoriteNotifications: [(peerID: PeerID, isFavorite: Bool)] = []
private(set) var sentBroadcastFiles: [(packet: BitchatFilePacket, transferID: String)] = []
private(set) var sentPrivateFiles: [(packet: BitchatFilePacket, peerID: PeerID, transferID: String)] = []
private(set) var cancelledTransfers: [String] = []
private(set) var sentVerifyChallenges: [(peerID: PeerID, noiseKeyHex: String, nonceA: Data)] = []
private(set) var sentVerifyResponses: [(peerID: PeerID, noiseKeyHex: String, nonceA: Data)] = []
private(set) var sentCourierMessages: [(content: String, messageID: String, recipientNoiseKey: Data, couriers: [PeerID])] = []
private(set) var startServicesCallCount = 0
private(set) var stopServicesCallCount = 0
private(set) var emergencyDisconnectCallCount = 0
private(set) var broadcastAnnounceCallCount = 0
private(set) var triggeredHandshakes: [PeerID] = []
// MARK: - Configurable Mock State
var connectedPeers: Set<PeerID> = []
var reachablePeers: Set<PeerID> = []
var peerNicknames: [PeerID: String] = [:]
var peerFingerprints: [PeerID: String] = [:]
var peerNoiseStates: [PeerID: LazyHandshakeState] = [:]
private let mockKeychain = MockKeychain()
// MARK: - Transport Protocol Implementation
func currentPeerSnapshots() -> [TransportPeerSnapshot] {
peerSnapshotSubject.value
}
func setNickname(_ nickname: String) {
myNickname = nickname
}
func startServices() {
startServicesCallCount += 1
}
func stopServices() {
stopServicesCallCount += 1
}
func emergencyDisconnectAll() {
emergencyDisconnectCallCount += 1
connectedPeers.removeAll()
reachablePeers.removeAll()
}
func isPeerConnected(_ peerID: PeerID) -> Bool {
connectedPeers.contains(peerID)
}
func isPeerReachable(_ peerID: PeerID) -> Bool {
reachablePeers.contains(peerID) || connectedPeers.contains(peerID)
}
func peerNickname(peerID: PeerID) -> String? {
peerNicknames[peerID]
}
func getPeerNicknames() -> [PeerID: String] {
peerNicknames
}
func getFingerprint(for peerID: PeerID) -> String? {
peerFingerprints[peerID]
}
func getNoiseSessionState(for peerID: PeerID) -> LazyHandshakeState {
peerNoiseStates[peerID] ?? .none
}
func triggerHandshake(with peerID: PeerID) {
triggeredHandshakes.append(peerID)
}
// Noise identity wrappers backed by a mock-keychain encryption service
// (mirrors the previous `getNoiseService()` placeholder behavior: a real
// identity, but no peer sessions). Exposed so tests can assert against
// the same identity the wrappers use.
private(set) lazy var mockNoiseService = NoiseEncryptionService(keychain: mockKeychain)
func noiseSessionPublicKeyData(for peerID: PeerID) -> Data? {
mockNoiseService.getPeerPublicKeyData(peerID)
}
func noiseIdentityFingerprint() -> String {
mockNoiseService.getIdentityFingerprint()
}
func noiseStaticPublicKeyData() -> Data {
mockNoiseService.getStaticPublicKeyData()
}
func noiseSigningPublicKeyData() -> Data {
mockNoiseService.getSigningPublicKeyData()
}
func noiseSignData(_ data: Data) -> Data? {
mockNoiseService.signData(data)
}
func noiseVerifySignature(_ signature: Data, for data: Data, publicKey: Data) -> Bool {
mockNoiseService.verifySignature(signature, for: data, publicKey: publicKey)
}
// MARK: - Messaging
func sendMessage(_ content: String, mentions: [String]) {
sentMessages.append((content, mentions, nil, nil))
}
func sendMessage(_ content: String, mentions: [String], messageID: String, timestamp: Date) {
sentMessages.append((content, mentions, messageID, timestamp))
}
func sendPrivateMessage(_ content: String, to peerID: PeerID, recipientNickname: String, messageID: String) {
sentPrivateMessages.append((content, peerID, recipientNickname, messageID))
}
func sendReadReceipt(_ receipt: ReadReceipt, to peerID: PeerID) {
sentReadReceipts.append((receipt, peerID))
}
func sendFavoriteNotification(to peerID: PeerID, isFavorite: Bool) {
sentFavoriteNotifications.append((peerID, isFavorite))
}
func sendBroadcastAnnounce() {
broadcastAnnounceCallCount += 1
}
func sendDeliveryAck(for messageID: String, to peerID: PeerID) {
sentDeliveryAcks.append((messageID, peerID))
}
func sendFileBroadcast(_ packet: BitchatFilePacket, transferId: String) {
sentBroadcastFiles.append((packet, transferId))
}
func sendFilePrivate(_ packet: BitchatFilePacket, to peerID: PeerID, transferId: String) {
sentPrivateFiles.append((packet, peerID, transferId))
}
func cancelTransfer(_ transferId: String) {
cancelledTransfers.append(transferId)
}
func sendVerifyChallenge(to peerID: PeerID, noiseKeyHex: String, nonceA: Data) {
sentVerifyChallenges.append((peerID, noiseKeyHex, nonceA))
}
func sendVerifyResponse(to peerID: PeerID, noiseKeyHex: String, nonceA: Data) {
sentVerifyResponses.append((peerID, noiseKeyHex, nonceA))
}
var courierSendResult = true
func sendCourierMessage(_ content: String, messageID: String, recipientNoiseKey: Data, via couriers: [PeerID]) -> Bool {
sentCourierMessages.append((content, messageID, recipientNoiseKey, couriers))
return courierSendResult
}
// MARK: - Mesh Diagnostics
private(set) var sentMeshPings: [PeerID] = []
var meshPingResult: MeshPingResult?
var meshPaths: [PeerID: [PeerID]] = [:]
var meshTopologySnapshot: MeshTopologySnapshot?
func sendMeshPing(to peerID: PeerID, completion: @escaping @MainActor (MeshPingResult?) -> Void) {
sentMeshPings.append(peerID)
let result = meshPingResult
Task { @MainActor in completion(result) }
}
func computeMeshPath(to peerID: PeerID) -> [PeerID]? {
meshPaths[peerID]
}
func currentMeshTopology() -> MeshTopologySnapshot? {
meshTopologySnapshot
}
// MARK: - Test Helpers
/// Clears all recorded method calls for fresh assertions
func resetRecordings() {
sentMessages.removeAll()
sentPrivateMessages.removeAll()
sentReadReceipts.removeAll()
sentDeliveryAcks.removeAll()
sentFavoriteNotifications.removeAll()
sentBroadcastFiles.removeAll()
sentPrivateFiles.removeAll()
cancelledTransfers.removeAll()
sentVerifyChallenges.removeAll()
sentVerifyResponses.removeAll()
startServicesCallCount = 0
stopServicesCallCount = 0
emergencyDisconnectCallCount = 0
broadcastAnnounceCallCount = 0
triggeredHandshakes.removeAll()
}
/// Simulates a peer connecting
func simulateConnect(_ peerID: PeerID, nickname: String? = nil) {
connectedPeers.insert(peerID)
if let nickname = nickname {
peerNicknames[peerID] = nickname
}
delegate?.didConnectToPeer(peerID)
delegate?.didUpdatePeerList(Array(connectedPeers))
publishPeerSnapshots()
}
/// Simulates a peer disconnecting
func simulateDisconnect(_ peerID: PeerID) {
connectedPeers.remove(peerID)
peerNicknames.removeValue(forKey: peerID)
delegate?.didDisconnectFromPeer(peerID)
delegate?.didUpdatePeerList(Array(connectedPeers))
publishPeerSnapshots()
}
/// Simulates receiving a message
func simulateIncomingMessage(_ message: BitchatMessage) {
delegate?.didReceiveMessage(message)
}
/// Simulates receiving a public message
func simulateIncomingPublicMessage(
from peerID: PeerID,
nickname: String,
content: String,
timestamp: Date = Date(),
messageID: String? = nil
) {
delegate?.didReceivePublicMessage(
from: peerID,
nickname: nickname,
content: content,
timestamp: timestamp,
messageID: messageID
)
}
/// Simulates Bluetooth state change
func simulateBluetoothStateChange(_ state: CBManagerState) {
delegate?.didUpdateBluetoothState(state)
}
/// Updates the peer snapshot publisher
func updatePeerSnapshots(_ snapshots: [TransportPeerSnapshot]) {
peerSnapshotSubject.send(snapshots)
Task { @MainActor [weak self] in
self?.peerEventsDelegate?.didUpdatePeerSnapshots(snapshots)
}
}
private func publishPeerSnapshots() {
let now = Date()
let snapshots = connectedPeers.map { peerID in
TransportPeerSnapshot(
peerID: peerID,
nickname: peerNicknames[peerID] ?? "",
isConnected: true,
noisePublicKey: Data(hexString: peerID.bare),
lastSeen: now
)
}
updatePeerSnapshots(snapshots)
}
}