mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-24 22:25:18 +00:00
ef848857b7
Periphery 3.7.4 audit of both schemes (macOS + iOS, intersected so platform-specific code is never touched), with test targets indexed and the share extension built. 277 dead declarations removed or demoted: dead forwarding wrappers (ChatViewModel+Nostr/+PrivateChat), removed- feature remnants (autocomplete command suggestions, back-swipe tuning, MediaSendError, GeohashParticipantTracker), unused Tor dormancy bindings, assign-only properties, unused parameters (renamed to _), and redundant public accessibility. 13 orphaned localization keys deleted across all 29 locales (old pre-#1392 location-notes UI, app_info warnings). Two real tests were flagged as unused because they never ran: Swift Testing methods missing @Test (NostrProtocolTests. testAckRoundTripNIP44V2_Delivered, NotificationStreamAssemblerTests. testAssemblesCompressedLargeFrame). Re-armed both; they pass. Deliberately kept, now recorded in .periphery.baseline.json: iOS-only code invisible to the CI macOS scan, C FFI signatures, keep-alive NWPathMonitor reference, InboundEventKey.eventID (dedup semantics), wifiBulk capability bit (reserved for Wi-Fi bulk work, used by BitFoundation package tests), and the String secureClear cluster (exercised by package tests). New: .periphery.yml config and an advisory Dead Code CI job (mirrors the SwiftLint precedent from #1361) that fails on findings not in the committed baseline. Verified: full macOS app suite, BitFoundation (119) and BitLogger (13) package tests green; periphery scan --strict exits clean. Co-authored-by: jack <jackjackbits@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
63 lines
2.1 KiB
Swift
63 lines
2.1 KiB
Swift
//
|
|
// BitchatMessage+Media.swift
|
|
// bitchat
|
|
//
|
|
// This is free and unencumbered software released into the public domain.
|
|
// For more information, see <https://unlicense.org>
|
|
//
|
|
|
|
import BitFoundation
|
|
import Foundation
|
|
|
|
extension BitchatMessage {
|
|
enum Media {
|
|
case voice(URL)
|
|
case image(URL)
|
|
}
|
|
|
|
// Cache the directory lookup to avoid repeated FileManager calls during view rendering
|
|
private struct Cache {
|
|
let filesDir: URL?
|
|
|
|
static let shared = Cache()
|
|
private init() {
|
|
do {
|
|
let base = try FileManager.default.url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
|
|
let filesDir = base.appendingPathComponent("files", isDirectory: true)
|
|
try FileManager.default.createDirectory(at: filesDir, withIntermediateDirectories: true, attributes: nil)
|
|
self.filesDir = filesDir
|
|
} catch {
|
|
filesDir = nil
|
|
}
|
|
}
|
|
}
|
|
|
|
func mediaAttachment(for nickname: String) -> Media? {
|
|
guard let baseDirectory = Cache.shared.filesDir else { return nil }
|
|
|
|
func url(for category: MimeType.Category) -> URL? {
|
|
guard content.hasPrefix(category.messagePrefix),
|
|
let filename = String(content.dropFirst(category.messagePrefix.count)).trimmedOrNilIfEmpty
|
|
else {
|
|
return nil
|
|
}
|
|
|
|
// Check outgoing first for sent messages, incoming for received
|
|
let subdir = sender == nickname ? "\(category.mediaDir)/outgoing" : "\(category.mediaDir)/incoming"
|
|
|
|
// Construct URL directly without fileExists check (avoids blocking disk I/O in view body)
|
|
// Files are checked during playback/display, so missing files fail gracefully
|
|
let directory = baseDirectory.appendingPathComponent(subdir, isDirectory: true)
|
|
return directory.appendingPathComponent(filename)
|
|
}
|
|
|
|
if let url = url(for: .audio) {
|
|
return .voice(url)
|
|
}
|
|
if let url = url(for: .image) {
|
|
return .image(url)
|
|
}
|
|
return nil
|
|
}
|
|
}
|