mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-24 23:45:18 +00:00
jackandClaude Opus 4.5
09818a02ed
Block notifications from bypassing the user blocking feature on iOS. Vulnerabilities fixed: 1. Nostr public messages: checkForMentions() was called regardless of blocking status, allowing blocked users to trigger mention notifications 2. Noise-encrypted DMs: didReceiveNoisePayload() didn't check blocking before calling handlePrivateMessage(), allowing DM notifications Changes: - ChatViewModel+Nostr.swift: Add blocking check before checkForMentions() and sendHapticFeedback() in subscribeNostrEvent - ChatViewModel.swift: Add isPeerBlocked() check in didReceiveNoisePayload before processing private messages - Add NotificationBlockingTests.swift with 5 tests for blocking behavior Security: Blocked users can no longer trigger notifications through any message path (Nostr public, Nostr DM, or BLE Noise DM). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
112 lines
3.7 KiB
Swift
112 lines
3.7 KiB
Swift
//
|
|
// NotificationBlockingTests.swift
|
|
// bitchatTests
|
|
//
|
|
// This is free and unencumbered software released into the public domain.
|
|
// For more information, see <https://unlicense.org>
|
|
//
|
|
// BCH-01-012: Tests for notification blocking feature
|
|
|
|
import Testing
|
|
import Foundation
|
|
@testable import bitchat
|
|
|
|
struct NotificationBlockingTests {
|
|
|
|
// MARK: - Nostr Blocking Tests
|
|
|
|
@Test("isNostrBlocked returns true for blocked pubkeys")
|
|
func isNostrBlocked_returnsTrueForBlockedPubkey() {
|
|
let keychain = MockKeychain()
|
|
let manager = MockIdentityManager(keychain)
|
|
|
|
let testPubkey = "abc123def456".lowercased()
|
|
|
|
// Initially not blocked
|
|
#expect(manager.isNostrBlocked(pubkeyHexLowercased: testPubkey) == false)
|
|
|
|
// Block the pubkey
|
|
manager.setNostrBlocked(testPubkey, isBlocked: true)
|
|
|
|
// Now should be blocked
|
|
#expect(manager.isNostrBlocked(pubkeyHexLowercased: testPubkey) == true)
|
|
|
|
// Unblock
|
|
manager.setNostrBlocked(testPubkey, isBlocked: false)
|
|
#expect(manager.isNostrBlocked(pubkeyHexLowercased: testPubkey) == false)
|
|
}
|
|
|
|
@Test("isBlocked returns true for blocked fingerprints")
|
|
func isBlocked_returnsTrueForBlockedFingerprint() {
|
|
let keychain = MockKeychain()
|
|
let manager = MockIdentityManager(keychain)
|
|
|
|
let testFingerprint = "fingerprint123"
|
|
|
|
// Initially not blocked
|
|
#expect(manager.isBlocked(fingerprint: testFingerprint) == false)
|
|
|
|
// Block the fingerprint
|
|
manager.setBlocked(testFingerprint, isBlocked: true)
|
|
|
|
// Now should be blocked
|
|
#expect(manager.isBlocked(fingerprint: testFingerprint) == true)
|
|
|
|
// Unblock
|
|
manager.setBlocked(testFingerprint, isBlocked: false)
|
|
#expect(manager.isBlocked(fingerprint: testFingerprint) == false)
|
|
}
|
|
|
|
@Test("getBlockedNostrPubkeys returns all blocked pubkeys")
|
|
func getBlockedNostrPubkeys_returnsAllBlocked() {
|
|
let keychain = MockKeychain()
|
|
let manager = MockIdentityManager(keychain)
|
|
|
|
let pubkey1 = "pubkey1".lowercased()
|
|
let pubkey2 = "pubkey2".lowercased()
|
|
let pubkey3 = "pubkey3".lowercased()
|
|
|
|
manager.setNostrBlocked(pubkey1, isBlocked: true)
|
|
manager.setNostrBlocked(pubkey2, isBlocked: true)
|
|
manager.setNostrBlocked(pubkey3, isBlocked: true)
|
|
|
|
let blocked = manager.getBlockedNostrPubkeys()
|
|
|
|
#expect(blocked.count == 3)
|
|
#expect(blocked.contains(pubkey1))
|
|
#expect(blocked.contains(pubkey2))
|
|
#expect(blocked.contains(pubkey3))
|
|
}
|
|
|
|
// MARK: - Message Blocking Tests
|
|
|
|
@Test("BitchatMessage with blocked sender is identified")
|
|
func bitchatMessage_blockedSenderIdentified() {
|
|
let keychain = MockKeychain()
|
|
let manager = MockIdentityManager(keychain)
|
|
|
|
let blockedFingerprint = "blocked_fingerprint_123"
|
|
manager.setBlocked(blockedFingerprint, isBlocked: true)
|
|
|
|
#expect(manager.isBlocked(fingerprint: blockedFingerprint) == true)
|
|
}
|
|
|
|
@Test("Case insensitive blocking for Nostr pubkeys")
|
|
func nostrBlocking_caseInsensitive() {
|
|
let keychain = MockKeychain()
|
|
let manager = MockIdentityManager(keychain)
|
|
|
|
let pubkeyLower = "abc123def456"
|
|
|
|
// Block lowercase
|
|
manager.setNostrBlocked(pubkeyLower, isBlocked: true)
|
|
|
|
// Check lowercase is blocked
|
|
#expect(manager.isNostrBlocked(pubkeyHexLowercased: pubkeyLower) == true)
|
|
|
|
// Note: The API expects lowercased input, so callers must normalize
|
|
// This test verifies the contract that pubkeys should be lowercased before checking
|
|
// The fix in ChatViewModel+Nostr.swift normalizes via event.pubkey.lowercased()
|
|
}
|
|
}
|