mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-24 23:45:18 +00:00
jackandClaude Fable 5
fa136d8973
The intermittent CI hang was caught by the new job timeout: the run froze on the last remaining parallel test slot, an XCTest measure benchmark (testNostrInboundEventHandling_freshEvents), after 4 hangs in 5 runs - while the same suite completes in seconds locally and the test itself is bounded. Independent of the micro-cause, benchmarks do not belong inside the parallel suite: measuring while test processes contend for cores is where our 2x CI variance came from. The parallel run now skips benchmarks (BITCHAT_SKIP_PERF_BASELINES=1) and a dedicated serial step runs them on an otherwise idle runner with a 6-minute step timeout, feeding the floor gate as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
107 lines
4.0 KiB
YAML
107 lines
4.0 KiB
YAML
name: Build & Test
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
pull_request:
|
|
|
|
jobs:
|
|
test:
|
|
name: Run Swift Tests (${{ matrix.name }})
|
|
runs-on: macos-latest
|
|
# A hung test must fail fast, not hold a runner for GitHub's 360-minute
|
|
# default (observed: intermittent app-suite hangs starving the queue).
|
|
timeout-minutes: 15
|
|
|
|
strategy:
|
|
fail-fast: false # Don't cancel other matrix jobs when one fails
|
|
matrix:
|
|
include:
|
|
- name: app
|
|
path: .
|
|
- name: BitLogger
|
|
path: localPackages/BitLogger
|
|
- name: BitFoundation
|
|
path: localPackages/BitFoundation
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v5
|
|
|
|
- name: Set up Swift
|
|
uses: swift-actions/setup-swift@v2
|
|
|
|
- name: Cache build artifacts
|
|
uses: actions/cache@v4
|
|
with:
|
|
path: ${{ matrix.path }}/.build
|
|
key: ${{ runner.os }}-${{ matrix.name }}-${{ hashFiles(format('{0}/**/*.swift', matrix.path), format('{0}/**/Package.resolved', matrix.path)) }}
|
|
restore-keys: |
|
|
${{ runner.os }}-${{ matrix.name }}-${{ hashFiles(format('{0}/**/Package.resolved', matrix.path)) }}
|
|
${{ runner.os }}-${{ matrix.name }}-
|
|
|
|
- name: Run Tests
|
|
# Perf benchmarks are excluded here and run in their own serial step
|
|
# below: measuring while parallel test processes contend for cores
|
|
# produces noisy numbers, and the XCTest measure machinery has hung
|
|
# intermittently under parallel workers on loaded runners.
|
|
env:
|
|
BITCHAT_SKIP_PERF_BASELINES: "1"
|
|
run: swift test --parallel --quiet --enable-code-coverage --package-path ${{ matrix.path }}
|
|
|
|
# Benchmarks run serially on an otherwise idle runner for stable
|
|
# numbers; BITCHAT_PERF_LOG captures the PERF[...] lines for the gate.
|
|
- name: Run performance benchmarks (serial)
|
|
if: matrix.name == 'app'
|
|
timeout-minutes: 6
|
|
env:
|
|
BITCHAT_PERF_LOG: ${{ github.workspace }}/perf-output.log
|
|
run: swift test --quiet --filter PerformanceBaselineTests
|
|
|
|
# Order-of-magnitude performance regression gate. Floors are deliberately
|
|
# generous (see bitchatTests/Performance/perf-floors.json) so this
|
|
# catches algorithmic regressions, never runner variance.
|
|
- name: Performance floor gate
|
|
if: matrix.name == 'app'
|
|
run: ./scripts/check-perf-floors.sh perf-output.log
|
|
|
|
# Informational only: surfaces per-file and total line coverage in the
|
|
# job log so coverage trends are visible on every PR. No thresholds —
|
|
# this must never be the reason a build goes red.
|
|
- name: Coverage summary
|
|
run: |
|
|
BIN_PATH=$(swift build --show-bin-path --package-path ${{ matrix.path }})
|
|
PROF="$BIN_PATH/codecov/default.profdata"
|
|
XCTEST=$(find "$BIN_PATH" -maxdepth 1 -name '*.xctest' | head -1)
|
|
BINARY="$XCTEST/Contents/MacOS/$(basename "$XCTEST" .xctest)"
|
|
if [ -f "$PROF" ] && [ -f "$BINARY" ]; then
|
|
xcrun llvm-cov report "$BINARY" -instr-profile "$PROF" \
|
|
-ignore-filename-regex='(Tests|\.build|checkouts|Mocks|_PreviewHelpers)' || true
|
|
else
|
|
echo "No coverage data found; skipping summary."
|
|
fi
|
|
|
|
# SPM tests above only compile the macOS slice; this job covers the
|
|
# iOS-conditional code paths (UIKit, CoreBluetooth restoration, etc.).
|
|
ios-build:
|
|
name: Build iOS app (simulator)
|
|
runs-on: macos-latest
|
|
timeout-minutes: 15
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v5
|
|
|
|
- name: Build iOS (simulator, no signing)
|
|
# arm64 only: the vendored arti.xcframework has no x86_64 simulator slice.
|
|
run: |
|
|
set -o pipefail
|
|
xcodebuild -project bitchat.xcodeproj \
|
|
-scheme "bitchat (iOS)" \
|
|
-sdk iphonesimulator \
|
|
-destination 'generic/platform=iOS Simulator' \
|
|
ARCHS=arm64 \
|
|
CODE_SIGNING_ALLOWED=NO \
|
|
build
|