mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-25 09:05:20 +00:00
* Friend-courier store-and-forward: mutual favorites carry sealed messages to offline peers When a private message has no reachable transport, the router now seals it to the recipient's Noise static key (new one-way Noise X pattern) and hands the envelope to up to three connected mutual favorites. Couriers store the opaque ciphertext under strict quotas (20 total, 5 per depositor, 16 KiB, 24 h) and hand it over when the recipient's announce matches a rotating HMAC recipient tag; the recipient opens it and the message flows through the normal private-message pipeline, so dedup and delivery acks just work. - CourierEnvelope TLV + courierEnvelope (0x04) message type in BitFoundation - Noise X one-way pattern reusing the existing handshake machinery, domain-separated by a courier prologue; sender identity authenticated via the ss DH (no forward secrecy - documented tradeoff) - CourierStore with eviction, file persistence, and panic-wipe integration - Rotating recipient tags (HMAC over epoch day) so carried envelopes don't correlate for observers who don't already know the recipient's key - New "carried" delivery status with figure.walk glyph; header indicator while carrying mail for others - Three-node end-to-end test ferrying packets through real BLEService instances, plus codec/crypto/store/router suites (986 tests green) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix courier handoff verification and directed sends * Authenticate courier deposits by ingress peer * Gate courier handover on direct announces and isolate store test Envelopes are removed from the courier store optimistically, so releasing them on a relayed (multi-hop) announce risks losing carried mail to a speculative flood that never reaches the recipient. Handover now also requires the announce to have arrived directly (full TTL), i.e. an actual encounter with a live link; regression test builds a relayed copy of a genuinely signed announce (TTL is excluded from announce signatures). Also make CourierStore's on-disk location injectable so the persistence test round-trips through a temp directory instead of wiping the real Application Support store, and reattach BLEAnnounceHandler's doc comment to the class it describes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Use Xcode-bundled Swift in CI instead of a standalone toolchain The unpinned setup-swift action installs Swift 6.1, which refuses the SDK on runner images that have rolled to Xcode 26.5 ("this SDK is not supported by the compiler"). Jobs passed or failed depending on which image they landed on. The Xcode-bundled toolchain always matches the image's SDK, and matches local development. Cache keys now include the toolchain version so artifacts from one compiler are never restored into builds with another. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Drop couriered mail from blocked senders at envelope open The UI-layer block check (isPeerBlocked in the transport event coordinator) resolves a fingerprint from the live session or peer list, but a couriered message arrives precisely when its sender is absent — no session, no registry entry — so the check failed open and a blocked identity's mail was delivered anyway. Gate in openCourierEnvelope, where the sealed sender's full static key is in hand. End-to-end test ferries a full deposit→carry→handover round and verifies the envelope from a blocked sender never reaches the delegate (confirmed failing without the gate). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix favorites end-to-end: peer-list dedup, Nostr sync, /fav key corruption - UnifiedPeerService: dedup offline favorites against mesh peers by noise key. Phase 2 compared a 64-hex noise-key PeerID against 16-hex mesh IDs (never equal), leaving only a nickname+isConnected heuristic — a mutual favorite that was reachable-but-not-connected or renamed rendered twice, and a same-nick stranger could suppress a favorite entirely. - Nostr inbound: intercept [FAVORITED]/[UNFAVORITED] markers in the live PM handler so they update theyFavoritedUs instead of rendering as chat text; mutual favorites can now form over Nostr. Delete the dead favorite-aware PM variant and ChatNostrCoordinator.handleFavoriteNotification (unwired, parsed a stale FAVORITE:TRUE|… format no sender emits). - NostrTransport.isPeerReachable: match short form regardless of incoming ID width — toggling an offline favorite (addressed by 64-hex noise key) was silently dropped with no reachable transport. - BLEService.sendPrivateMessage: normalize recipient to the short ID like sendFilePrivate, so a 64-hex target hits the existing Noise session instead of initiating a handshake with a 32-byte wire recipient ID. - /fav, /unfav: stop writing Data(hexString: peerID.id) — the 8-byte routing ID for mesh peers — into the favorites store as a "noise key", and stop double-sending the favorite notification; delegate to toggleFavorite with a proper state check. - FavoritesPersistenceService.updatePeerFavoritedUs: keep the stored nickname when the caller passes the "Unknown" placeholder. - Bump marketing version to 1.5.4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Route DMs to mutual favorites via Nostr when a mesh-keyed peer goes offline Field-tested on device: with a DM window opened while the peer was on mesh (conversation keyed by the short 16-hex ID), walking out of range and sending failed instantly with "peer not reachable" even though the header showed the peer as Nostr-reachable (mutual favorite, npub known). sendPrivateMessage derived the favorites key as Data(hexString: peerID.id) — for a short mesh ID that is the 8-byte routing ID, never the noise key — so the mutual-favorite/Nostr-key checks always came up empty and the send failed before reaching MessageRouter. Conversations keyed by the full 64-hex noise-key ID (opened from the offline favorite row) were unaffected, which is why later tests appeared to work. Resolve the noise key properly (peerID.noiseKey, then the unified peer row, then the favorites store by derived short ID) and add a regression test for the mesh-keyed-peer-goes-offline case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Label Nostr DMs from favorites with their stored nickname Field-tested: a DM delivered over the Nostr fallback rendered as "anon#678e" instead of the sender's name. The inbound handler named the sender via displayNameForNostrPubkey, which only knows geohash-scoped names — even though the pipeline had already resolved the sender's noise key (the conversation is keyed by it). When the conversation key carries a noise key, prefer the favorite's stored nickname; geohash DMs (nostr_ keys) keep the anon geo name. This also stops an inbound Nostr [FAVORITED] from overwriting the stored nickname with the anon fallback, since the same name feeds updatePeerFavoritedUs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix courier path for offline favorites addressed by noise-key IDs Two Codex review findings, both the same ID-width confusion this PR targets, in the courier flow: - CourierDirectory.favoritesBacked resolved recipients only via getFavoriteStatus(forPeerID:), which requires a short 16-hex ID — offline favorites are addressed by the full 64-hex noise-key ID, so attemptCourierDeposit silently bailed for exactly the peers couriers exist to serve. The 64-hex ID now yields its own key directly. - openCourierEnvelope emitted the derived short mesh ID even when the sender has no live mesh identity, landing couriered mail in an unresolvable short-ID thread labeled "Unknown". Absent senders now emit the full noise-key ID so the message joins the stable favorite conversation; present senders keep the live short-ID thread. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: jack <jackjackbits@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
335 lines
13 KiB
Swift
335 lines
13 KiB
Swift
import BitLogger
|
|
import BitFoundation
|
|
import Foundation
|
|
import Combine
|
|
|
|
/// Manages persistent favorite relationships between peers
|
|
@MainActor
|
|
final class FavoritesPersistenceService: ObservableObject {
|
|
|
|
struct FavoriteRelationship: Codable {
|
|
let peerNoisePublicKey: Data
|
|
let peerNostrPublicKey: String?
|
|
let peerNickname: String
|
|
let isFavorite: Bool
|
|
let theyFavoritedUs: Bool
|
|
let favoritedAt: Date
|
|
let lastUpdated: Date
|
|
// Track what we last sent as OUR npub to this peer, to avoid resending unless it changes
|
|
// Note: we do not track which npub we last sent to them; sending happens only on favorite toggle
|
|
|
|
var isMutual: Bool {
|
|
isFavorite && theyFavoritedUs
|
|
}
|
|
}
|
|
|
|
// We intentionally do not track when we last sent our npub; sending happens only on favorite toggle.
|
|
|
|
private static let storageKey = "chat.bitchat.favorites"
|
|
private static let keychainService = "chat.bitchat.favorites"
|
|
private let keychain: KeychainManagerProtocol
|
|
|
|
@Published private(set) var favorites: [Data: FavoriteRelationship] = [:] // Noise pubkey -> relationship
|
|
@Published private(set) var mutualFavorites: Set<Data> = []
|
|
|
|
static let shared = FavoritesPersistenceService()
|
|
|
|
/// Default keychain for the `shared` singleton. Under test this is an
|
|
/// in-memory keychain so touching `shared` never blocks on securityd
|
|
/// (`SecItemCopyMatching` can hang in test environments) and never reads
|
|
/// or writes the developer's real keychain. Production behavior is
|
|
/// unchanged. Tests that need their own instance keep injecting a mock
|
|
/// via `init(keychain:)`.
|
|
private nonisolated static func makeDefaultKeychain() -> KeychainManagerProtocol {
|
|
// PreviewKeychainManager lives in _PreviewHelpers, a development
|
|
// asset excluded from archive builds — release code must not
|
|
// reference it. Tests always run Debug, so the guard is lossless.
|
|
#if DEBUG
|
|
if TestEnvironment.isRunningTests { return PreviewKeychainManager() }
|
|
#endif
|
|
return KeychainManager()
|
|
}
|
|
|
|
init(keychain: KeychainManagerProtocol = FavoritesPersistenceService.makeDefaultKeychain()) {
|
|
self.keychain = keychain
|
|
loadFavorites()
|
|
|
|
// Update mutual favorites when favorites change
|
|
$favorites
|
|
.map { favorites in
|
|
Set(favorites.compactMap { $0.value.isMutual ? $0.key : nil })
|
|
}
|
|
.assign(to: &$mutualFavorites)
|
|
}
|
|
|
|
/// Add or update a favorite
|
|
func addFavorite(
|
|
peerNoisePublicKey: Data,
|
|
peerNostrPublicKey: String? = nil,
|
|
peerNickname: String
|
|
) {
|
|
SecureLogger.info("⭐️ Adding favorite: \(peerNickname) (\(peerNoisePublicKey.hexEncodedString()))", category: .session)
|
|
|
|
let existing = favorites[peerNoisePublicKey]
|
|
|
|
let relationship = FavoriteRelationship(
|
|
peerNoisePublicKey: peerNoisePublicKey,
|
|
peerNostrPublicKey: peerNostrPublicKey ?? existing?.peerNostrPublicKey,
|
|
peerNickname: peerNickname,
|
|
isFavorite: true,
|
|
theyFavoritedUs: existing?.theyFavoritedUs ?? false,
|
|
favoritedAt: existing?.favoritedAt ?? Date(),
|
|
lastUpdated: Date()
|
|
)
|
|
|
|
// Log if this creates a mutual favorite
|
|
if relationship.isMutual {
|
|
SecureLogger.info("💕 Mutual favorite relationship established with \(peerNickname)!", category: .session)
|
|
}
|
|
|
|
favorites[peerNoisePublicKey] = relationship
|
|
saveFavorites()
|
|
|
|
// Notify observers
|
|
NotificationCenter.default.post(
|
|
name: .favoriteStatusChanged,
|
|
object: nil,
|
|
userInfo: ["peerPublicKey": peerNoisePublicKey]
|
|
)
|
|
}
|
|
|
|
/// Remove a favorite
|
|
func removeFavorite(peerNoisePublicKey: Data) {
|
|
guard let existing = favorites[peerNoisePublicKey] else { return }
|
|
|
|
SecureLogger.info("⭐️ Removing favorite: \(existing.peerNickname) (\(peerNoisePublicKey.hexEncodedString()))", category: .session)
|
|
|
|
// If they still favorite us, keep the record but mark us as not favoriting
|
|
if existing.theyFavoritedUs {
|
|
let updated = FavoriteRelationship(
|
|
peerNoisePublicKey: existing.peerNoisePublicKey,
|
|
peerNostrPublicKey: existing.peerNostrPublicKey,
|
|
peerNickname: existing.peerNickname,
|
|
isFavorite: false,
|
|
theyFavoritedUs: true,
|
|
favoritedAt: existing.favoritedAt,
|
|
lastUpdated: Date()
|
|
)
|
|
favorites[peerNoisePublicKey] = updated
|
|
// Keeping record - they still favorite us
|
|
} else {
|
|
// Neither side favorites, remove completely
|
|
favorites.removeValue(forKey: peerNoisePublicKey)
|
|
// Completely removed from favorites
|
|
}
|
|
|
|
saveFavorites()
|
|
|
|
// Notify observers
|
|
NotificationCenter.default.post(
|
|
name: .favoriteStatusChanged,
|
|
object: nil,
|
|
userInfo: ["peerPublicKey": peerNoisePublicKey]
|
|
)
|
|
}
|
|
|
|
/// Update when we learn a peer favorited/unfavorited us
|
|
func updatePeerFavoritedUs(
|
|
peerNoisePublicKey: Data,
|
|
favorited: Bool,
|
|
peerNickname: String? = nil,
|
|
peerNostrPublicKey: String? = nil
|
|
) {
|
|
let existing = favorites[peerNoisePublicKey]
|
|
// Callers that can't resolve the live nickname pass the "Unknown"
|
|
// placeholder (e.g. a notification arriving before the announce);
|
|
// never let it clobber a real stored nickname.
|
|
let incoming = peerNickname.flatMap { name in
|
|
(name.isEmpty || name == "Unknown") ? nil : name
|
|
}
|
|
let displayName = incoming ?? existing?.peerNickname ?? "Unknown"
|
|
|
|
SecureLogger.info("📨 Received favorite notification: \(displayName) \(favorited ? "favorited" : "unfavorited") us", category: .session)
|
|
|
|
let relationship = FavoriteRelationship(
|
|
peerNoisePublicKey: peerNoisePublicKey,
|
|
peerNostrPublicKey: peerNostrPublicKey ?? existing?.peerNostrPublicKey,
|
|
peerNickname: displayName,
|
|
isFavorite: existing?.isFavorite ?? false,
|
|
theyFavoritedUs: favorited,
|
|
favoritedAt: existing?.favoritedAt ?? Date(),
|
|
lastUpdated: Date()
|
|
)
|
|
|
|
if !relationship.isFavorite && !relationship.theyFavoritedUs {
|
|
// Neither side favorites, remove completely
|
|
favorites.removeValue(forKey: peerNoisePublicKey)
|
|
// Removed - neither side favorites anymore
|
|
} else {
|
|
favorites[peerNoisePublicKey] = relationship
|
|
|
|
// Check if this creates a mutual favorite
|
|
if relationship.isMutual {
|
|
SecureLogger.info("💕 Mutual favorite relationship established with \(displayName)!", category: .session)
|
|
}
|
|
}
|
|
|
|
saveFavorites()
|
|
|
|
// Notify observers
|
|
NotificationCenter.default.post(
|
|
name: .favoriteStatusChanged,
|
|
object: nil,
|
|
userInfo: ["peerPublicKey": peerNoisePublicKey]
|
|
)
|
|
}
|
|
|
|
/// Check if a peer is favorited by us
|
|
func isFavorite(_ peerNoisePublicKey: Data) -> Bool {
|
|
favorites[peerNoisePublicKey]?.isFavorite ?? false
|
|
}
|
|
|
|
/// Check if we have a mutual favorite relationship
|
|
func isMutualFavorite(_ peerNoisePublicKey: Data) -> Bool {
|
|
favorites[peerNoisePublicKey]?.isMutual ?? false
|
|
}
|
|
|
|
/// Get favorite status for a peer
|
|
func getFavoriteStatus(for peerNoisePublicKey: Data) -> FavoriteRelationship? {
|
|
favorites[peerNoisePublicKey]
|
|
}
|
|
|
|
/// Resolve favorite status by short peer ID (16-hex derived from Noise pubkey)
|
|
/// Falls back to scanning favorites and matching on derived peer ID.
|
|
func getFavoriteStatus(forPeerID peerID: PeerID) -> FavoriteRelationship? {
|
|
// Quick sanity: peerID should be 16 hex chars (8 bytes)
|
|
guard peerID.isShort else { return nil }
|
|
for (pubkey, rel) in favorites where PeerID(publicKey: pubkey) == peerID {
|
|
return rel
|
|
}
|
|
return nil
|
|
}
|
|
|
|
/// Clear all favorites - used for panic mode
|
|
func clearAllFavorites() {
|
|
SecureLogger.warning("🧹 Clearing all favorites (panic mode)", category: .session)
|
|
|
|
favorites.removeAll()
|
|
saveFavorites()
|
|
|
|
// Delete from keychain directly
|
|
keychain.delete(
|
|
key: Self.storageKey,
|
|
service: Self.keychainService
|
|
)
|
|
|
|
// Post notification for UI update
|
|
NotificationCenter.default.post(name: .favoriteStatusChanged, object: nil)
|
|
}
|
|
|
|
// MARK: - Persistence
|
|
|
|
private func saveFavorites() {
|
|
let relationships = Array(favorites.values)
|
|
// Saving favorite relationships to keychain
|
|
|
|
do {
|
|
let encoder = JSONEncoder()
|
|
let data = try encoder.encode(relationships)
|
|
|
|
// Store in keychain for security
|
|
keychain.save(
|
|
key: Self.storageKey,
|
|
data: data,
|
|
service: Self.keychainService,
|
|
accessible: nil
|
|
)
|
|
|
|
// Successfully saved favorites
|
|
} catch {
|
|
SecureLogger.error("Failed to save favorites: \(error)", category: .session)
|
|
}
|
|
}
|
|
|
|
private func loadFavorites() {
|
|
// Loading favorites from keychain
|
|
|
|
guard let data = keychain.load(
|
|
key: Self.storageKey,
|
|
service: Self.keychainService
|
|
) else {
|
|
return
|
|
}
|
|
|
|
do {
|
|
let decoder = JSONDecoder()
|
|
let relationships = try decoder.decode([FavoriteRelationship].self, from: data)
|
|
|
|
SecureLogger.info("✅ Loaded \(relationships.count) favorite relationships", category: .session)
|
|
|
|
// Log Nostr public key info
|
|
for relationship in relationships {
|
|
if relationship.peerNostrPublicKey == nil {
|
|
SecureLogger.warning("⚠️ No Nostr public key stored for '\(relationship.peerNickname)'", category: .session)
|
|
}
|
|
}
|
|
|
|
// Convert to dictionary, cleaning up duplicates by public key (not nickname)
|
|
var seenPublicKeys: [Data: FavoriteRelationship] = [:]
|
|
var cleanedRelationships: [FavoriteRelationship] = []
|
|
|
|
for relationship in relationships {
|
|
// Check for duplicates by public key (the actual unique identifier)
|
|
if let existing = seenPublicKeys[relationship.peerNoisePublicKey] {
|
|
SecureLogger.warning("⚠️ Duplicate favorite found for public key \(relationship.peerNoisePublicKey.hexEncodedString()) - nicknames: '\(existing.peerNickname)' vs '\(relationship.peerNickname)'", category: .session)
|
|
|
|
// Keep the most recent or most complete relationship
|
|
if relationship.lastUpdated > existing.lastUpdated ||
|
|
(relationship.peerNostrPublicKey != nil && existing.peerNostrPublicKey == nil) {
|
|
// Replace with newer/more complete entry
|
|
seenPublicKeys[relationship.peerNoisePublicKey] = relationship
|
|
cleanedRelationships.removeAll { $0.peerNoisePublicKey == relationship.peerNoisePublicKey }
|
|
cleanedRelationships.append(relationship)
|
|
}
|
|
} else {
|
|
seenPublicKeys[relationship.peerNoisePublicKey] = relationship
|
|
cleanedRelationships.append(relationship)
|
|
}
|
|
}
|
|
|
|
// If we cleaned up duplicates, save the cleaned list
|
|
if cleanedRelationships.count < relationships.count {
|
|
// Cleaned up duplicates
|
|
|
|
// Clear and rebuild favorites dictionary
|
|
favorites.removeAll()
|
|
for relationship in cleanedRelationships {
|
|
favorites[relationship.peerNoisePublicKey] = relationship
|
|
}
|
|
|
|
// Save cleaned favorites
|
|
saveFavorites()
|
|
|
|
// Notify that favorites have been cleaned up (synchronously since we're already on main actor)
|
|
NotificationCenter.default.post(name: .favoriteStatusChanged, object: nil)
|
|
} else {
|
|
// No duplicates, just populate normally
|
|
for relationship in cleanedRelationships {
|
|
favorites[relationship.peerNoisePublicKey] = relationship
|
|
}
|
|
}
|
|
|
|
// Log loaded relationships
|
|
// Loaded relationships successfully
|
|
} catch {
|
|
SecureLogger.error("Failed to load favorites: \(error)", category: .session)
|
|
}
|
|
}
|
|
}
|
|
|
|
// MARK: - Notification Names
|
|
|
|
extension Notification.Name {
|
|
static let favoriteStatusChanged = Notification.Name("FavoriteStatusChanged")
|
|
}
|