mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-25 03:45:20 +00:00
* Add mesh diagnostics: /ping, /trace, and topology map - New protocol types ping=0x26 / pong=0x27 (9-byte payload: 8-byte nonce + origin TTL) with per-peer inbound rate limiting (5 per 10s) - /ping @name reports RTT and hop count, 10s timeout - /trace @name prints the estimated path from gossiped directNeighbors - Topology map sheet (circular Canvas layout) reachable from App Info - Ping/pong ride the deterministic directed-relay path like DMs - Tests: payload round-trip, hop-count math, command output, edge normalization, layout Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix CI media-wipe race, per-link ping rate limiting, and /ping output routing Three fixes for PR #1377 review: 1. CI flake (sendImage_privateChatProcessesAndTransfersImage): the panicClearAllData / clearCurrentPublicTimeline detached utility-priority tasks delete the real ~/Library/Application Support/files tree, which the test process shares. The wipe fires at a nondeterministic time and raced the sendImage test's JPEG in files/images/outgoing (write then re-read), so prepareImagePacket threw and the test timed out. Both wipes are now skipped under tests (existing TestEnvironment.isRunningTests pattern); this also stops test runs from deleting the developer's real media. 2. Codex P1: ping packets are unsigned, so keying the pong rate limiter on packet.senderID let one connected peer rotate forged sender IDs to bypass the 5-per-10s budget. The limiter now keys on the ingress link (the directly connected peer that delivered the packet); the pong still goes to the claimed sender. Regression test proves rotating senders over one link exhaust one budget (fails 10 vs 5 pongs on the old code). 3. Codex P2: /ping output arrived up to 10s later and was routed from selectedPrivateChatPeer at callback time, misrouting the result after a chat switch. The origin conversation is now captured when the command is issued (CommandOutputDestination) and deferred output is routed there: a DM result lands in the origin chat's history even if deselected, and a mesh-timeline result pins to #mesh instead of the active channel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * App Info: move NETWORK section under HOW TO USE and uppercase NETWORK/SYMBOLS headers Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Conform DiagnosticsMockContext to sendPublicMessage CommandContextProvider gained sendPublicMessage (Cashu /pay, #1376) after this branch forked, so the diagnostics test mock no longer conformed once main was merged in. Add the no-op stub. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: jack <jackjackbits@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
166 lines
7.0 KiB
Swift
166 lines
7.0 KiB
Swift
import Foundation
|
|
|
|
/// Tracks observed mesh topology and computes hop-by-hop routes.
|
|
final class MeshTopologyTracker {
|
|
private typealias RoutingID = Data
|
|
|
|
private let queue = DispatchQueue(label: "mesh.topology", attributes: .concurrent)
|
|
private let hopSize = 8
|
|
// Directed claims: Key claims to see Value (neighbors)
|
|
private var claims: [RoutingID: Set<RoutingID>] = [:]
|
|
// Last time we received an update from a node
|
|
private var lastSeen: [RoutingID: Date] = [:]
|
|
// Highest protocol version observed from each node's decoded packets.
|
|
// Nodes absent from this map are assumed v1-only and are never used as
|
|
// hops (or targets) for version-gated routes.
|
|
private var observedVersions: [RoutingID: (version: UInt8, seenAt: Date)] = [:]
|
|
|
|
// Maximum age for topology claims to be considered fresh for routing
|
|
// Routes computed using stale topology can fail when the network has changed
|
|
private static let routeFreshnessThreshold: TimeInterval = 60 // 60 seconds
|
|
|
|
func reset() {
|
|
queue.sync(flags: .barrier) {
|
|
self.claims.removeAll()
|
|
self.lastSeen.removeAll()
|
|
self.observedVersions.removeAll()
|
|
}
|
|
}
|
|
|
|
/// Update the topology with a node's self-reported neighbor list
|
|
func updateNeighbors(for sourceData: Data?, neighbors: [Data], at now: Date = Date()) {
|
|
guard let source = sanitize(sourceData) else { return }
|
|
// Sanitize neighbors and exclude self-loops
|
|
let validNeighbors = Set(neighbors.compactMap { sanitize($0) }).subtracting([source])
|
|
|
|
queue.sync(flags: .barrier) {
|
|
self.claims[source] = validNeighbors
|
|
self.lastSeen[source] = now
|
|
}
|
|
}
|
|
|
|
/// Record the protocol version observed on a decoded packet from a node.
|
|
/// Only versions above the v1 baseline are stored; the highest wins.
|
|
func recordObservedVersion(_ version: UInt8, for peerData: Data?, at now: Date = Date()) {
|
|
guard version > 1, let peer = sanitize(peerData) else { return }
|
|
queue.sync(flags: .barrier) {
|
|
let current = self.observedVersions[peer]?.version ?? 1
|
|
self.observedVersions[peer] = (version: max(version, current), seenAt: now)
|
|
}
|
|
}
|
|
|
|
/// Raw directed neighbor claims, for diagnostics (topology map, /trace).
|
|
/// Callers treat the claims as advisory: announces cap `directNeighbors`
|
|
/// at 10, so an edge may be claimed by only one of its endpoints.
|
|
func adjacencySnapshot() -> [Data: Set<Data>] {
|
|
queue.sync { claims }
|
|
}
|
|
|
|
func removePeer(_ data: Data?) {
|
|
guard let peer = sanitize(data) else { return }
|
|
queue.sync(flags: .barrier) {
|
|
self.claims.removeValue(forKey: peer)
|
|
self.lastSeen.removeValue(forKey: peer)
|
|
self.observedVersions.removeValue(forKey: peer)
|
|
}
|
|
}
|
|
|
|
/// Prune nodes that haven't updated their topology in `age` seconds
|
|
func prune(olderThan age: TimeInterval, now: Date = Date()) {
|
|
let deadline = now.addingTimeInterval(-age)
|
|
queue.sync(flags: .barrier) {
|
|
let stale = self.lastSeen.filter { $0.value < deadline }
|
|
for (peer, _) in stale {
|
|
self.claims.removeValue(forKey: peer)
|
|
self.lastSeen.removeValue(forKey: peer)
|
|
}
|
|
self.observedVersions = self.observedVersions.filter { $0.value.seenAt >= deadline }
|
|
}
|
|
}
|
|
|
|
/// BFS over confirmed, fresh edges. When `requiringVersion` is set, every
|
|
/// node on the path except the source (i.e. all intermediate hops and the
|
|
/// target) must have been observed speaking at least that protocol
|
|
/// version — a v1-only hop cannot decode a v2 routed packet.
|
|
func computeRoute(from start: Data?, to goal: Data?, maxHops: Int = 10, requiringVersion: UInt8? = nil, now: Date = Date()) -> [Data]? {
|
|
guard let source = sanitize(start), let target = sanitize(goal) else { return nil }
|
|
if source == target { return [] } // Direct connection, no intermediate hops
|
|
|
|
return queue.sync {
|
|
let freshnessDeadline = now.addingTimeInterval(-Self.routeFreshnessThreshold)
|
|
func meetsRequiredVersion(_ peer: RoutingID) -> Bool {
|
|
guard let requiringVersion else { return true }
|
|
return (observedVersions[peer]?.version ?? 1) >= requiringVersion
|
|
}
|
|
|
|
// BFS
|
|
var visited: Set<RoutingID> = [source]
|
|
// Queue stores paths: [Start, Hop1, Hop2, ..., Current]
|
|
var queuePaths: [[RoutingID]] = [[source]]
|
|
|
|
while !queuePaths.isEmpty {
|
|
let path = queuePaths.removeFirst()
|
|
// Limit path length (path contains source + maxHops + target) -> maxHops intermediate
|
|
// If maxHops = 10, max edges = 11, max nodes = 12.
|
|
if path.count > maxHops + 1 { continue }
|
|
|
|
guard let last = path.last else { continue }
|
|
|
|
// Get neighbors that 'last' claims to see
|
|
guard let neighbors = claims[last] else { continue }
|
|
|
|
// Check if 'last' node's topology info is fresh
|
|
guard let lastSeenTime = lastSeen[last], lastSeenTime > freshnessDeadline else {
|
|
continue // Skip stale nodes
|
|
}
|
|
|
|
for neighbor in neighbors {
|
|
if visited.contains(neighbor) { continue }
|
|
|
|
// Version gate: skip nodes not known to speak the
|
|
// required protocol version.
|
|
guard meetsRequiredVersion(neighbor) else { continue }
|
|
|
|
// CONFIRMED EDGE CHECK:
|
|
// 'last' claims 'neighbor' (checked above)
|
|
// Does 'neighbor' claim 'last'?
|
|
guard let neighborClaims = claims[neighbor],
|
|
neighborClaims.contains(last) else {
|
|
continue
|
|
}
|
|
|
|
// Check if 'neighbor' node's topology info is fresh
|
|
guard let neighborSeenTime = lastSeen[neighbor], neighborSeenTime > freshnessDeadline else {
|
|
continue // Skip edges to stale nodes
|
|
}
|
|
|
|
var nextPath = path
|
|
nextPath.append(neighbor)
|
|
|
|
if neighbor == target {
|
|
// Return only intermediate hops
|
|
// Path: [Source, I1, I2, Target] -> [I1, I2]
|
|
return Array(nextPath.dropFirst().dropLast())
|
|
}
|
|
|
|
visited.insert(neighbor)
|
|
queuePaths.append(nextPath)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// MARK: - Helpers
|
|
|
|
private func sanitize(_ data: Data?) -> Data? {
|
|
guard var value = data, !value.isEmpty else { return nil }
|
|
if value.count > hopSize {
|
|
value = Data(value.prefix(hopSize))
|
|
} else if value.count < hopSize {
|
|
value.append(Data(repeating: 0, count: hopSize - value.count))
|
|
}
|
|
return value
|
|
}
|
|
}
|