mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-25 20:25:19 +00:00
* Extract each type to a separate file * Nostr ID Bridge: Convert static func/vars to instance * `KeychainHelper` behind a protocol to easily mock * Update tests with ID Bridge and MockKeychainHelper --------- Co-authored-by: jack <212554440+jackjackbits@users.noreply.github.com>
207 lines
8.0 KiB
Swift
207 lines
8.0 KiB
Swift
//
|
|
// FragmentationTests.swift
|
|
// bitchatTests
|
|
//
|
|
// This is free and unencumbered software released into the public domain.
|
|
// For more information, see <https://unlicense.org>
|
|
//
|
|
|
|
import Testing
|
|
import Foundation
|
|
import CoreBluetooth
|
|
@testable import bitchat
|
|
|
|
struct FragmentationTests {
|
|
|
|
private let mockKeychain: MockKeychain
|
|
private let mockIdentityManager: MockIdentityManager
|
|
private let idBridge: NostrIdentityBridge
|
|
|
|
init() {
|
|
mockKeychain = MockKeychain()
|
|
mockIdentityManager = MockIdentityManager(mockKeychain)
|
|
idBridge = NostrIdentityBridge(keychain: MockKeychainHelper())
|
|
}
|
|
|
|
@Test("Reassembly from fragments delivers a public message")
|
|
func reassemblyFromFragmentsDeliversPublicMessage() async throws {
|
|
let ble = BLEService(
|
|
keychain: mockKeychain,
|
|
idBridge: idBridge,
|
|
identityManager: mockIdentityManager
|
|
)
|
|
let capture = CaptureDelegate()
|
|
ble.delegate = capture
|
|
|
|
// Construct a big packet (3KB) from a remote sender (not our own ID)
|
|
let remoteShortID: PeerID = "1122334455667788"
|
|
let original = makeLargePublicPacket(senderShortHex: remoteShortID, size: 3_000)
|
|
|
|
// Use a small fragment size to ensure multiple pieces
|
|
let fragments = fragmentPacket(original, fragmentSize: 400)
|
|
|
|
// Shuffle fragments to simulate out-of-order arrival
|
|
let shuffled = fragments.shuffled()
|
|
|
|
// Inject fragments spaced out to avoid concurrent mutation inside BLEService
|
|
for (i, fragment) in shuffled.enumerated() {
|
|
let delay = UInt64(5 * i) * 1_000_000 // nanoseconds
|
|
Task {
|
|
try await Task.sleep(nanoseconds: delay)
|
|
ble._test_handlePacket(fragment, fromPeerID: remoteShortID)
|
|
}
|
|
}
|
|
|
|
// Allow async processing
|
|
try await Task.sleep(nanoseconds: 500_000_000) // 0.5s
|
|
|
|
#expect(capture.publicMessages.count == 1)
|
|
#expect(capture.publicMessages.first?.content.count == 3_000)
|
|
}
|
|
|
|
@Test("Duplicate fragment does not break reassembly")
|
|
func duplicateFragmentDoesNotBreakReassembly() async throws {
|
|
let ble = BLEService(
|
|
keychain: mockKeychain,
|
|
idBridge: idBridge,
|
|
identityManager: mockIdentityManager
|
|
)
|
|
let capture = CaptureDelegate()
|
|
ble.delegate = capture
|
|
|
|
let remoteShortID: PeerID = "A1B2C3D4E5F60708"
|
|
let original = makeLargePublicPacket(senderShortHex: remoteShortID, size: 2048)
|
|
var frags = fragmentPacket(original, fragmentSize: 300)
|
|
|
|
// Duplicate one fragment
|
|
if let dup = frags.first {
|
|
frags.insert(dup, at: 1)
|
|
}
|
|
|
|
for (i, fragment) in frags.enumerated() {
|
|
let delay = UInt64(5 * i) * 1_000_000 // nanoseconds
|
|
Task {
|
|
try await Task.sleep(nanoseconds: delay)
|
|
ble._test_handlePacket(fragment, fromPeerID: remoteShortID)
|
|
}
|
|
}
|
|
|
|
// Allow async processing
|
|
try await Task.sleep(nanoseconds: 500_000_000) // 0.5s
|
|
|
|
#expect(capture.publicMessages.count == 1)
|
|
#expect(capture.publicMessages.first?.content.count == 2048)
|
|
}
|
|
|
|
@Test("Invalid fragment header is ignored")
|
|
func invalidFragmentHeaderIsIgnored() async throws {
|
|
let ble = BLEService(
|
|
keychain: mockKeychain,
|
|
idBridge: idBridge,
|
|
identityManager: mockIdentityManager
|
|
)
|
|
let capture = CaptureDelegate()
|
|
ble.delegate = capture
|
|
|
|
let remoteShortID: PeerID = "0011223344556677"
|
|
let original = makeLargePublicPacket(senderShortHex: remoteShortID, size: 1000)
|
|
let fragments = fragmentPacket(original, fragmentSize: 250)
|
|
|
|
// Corrupt one fragment: make payload too short (header incomplete)
|
|
var corrupted = fragments
|
|
if !corrupted.isEmpty {
|
|
var p = corrupted[0]
|
|
p = BitchatPacket(
|
|
type: p.type,
|
|
senderID: p.senderID,
|
|
recipientID: p.recipientID,
|
|
timestamp: p.timestamp,
|
|
payload: Data([0x00, 0x01, 0x02]), // invalid header
|
|
signature: nil,
|
|
ttl: p.ttl
|
|
)
|
|
corrupted[0] = p
|
|
}
|
|
|
|
for (i, fragment) in corrupted.enumerated() {
|
|
let delay = UInt64(5 * i) * 1_000_000 // nanoseconds
|
|
Task {
|
|
try await Task.sleep(nanoseconds: delay)
|
|
ble._test_handlePacket(fragment, fromPeerID: remoteShortID)
|
|
}
|
|
}
|
|
|
|
// Allow async processing
|
|
try await Task.sleep(nanoseconds: 500_000_000) // 0.5s
|
|
|
|
// Should not deliver since one fragment is invalid and reassembly can't complete
|
|
#expect(capture.publicMessages.isEmpty)
|
|
}
|
|
}
|
|
|
|
extension FragmentationTests {
|
|
private final class CaptureDelegate: BitchatDelegate {
|
|
var publicMessages: [(peerID: PeerID, nickname: String, content: String)] = []
|
|
func didReceiveMessage(_ message: BitchatMessage) {}
|
|
func didConnectToPeer(_ peerID: PeerID) {}
|
|
func didDisconnectFromPeer(_ peerID: PeerID) {}
|
|
func didUpdatePeerList(_ peers: [PeerID]) {}
|
|
func isFavorite(fingerprint: String) -> Bool { false }
|
|
func didUpdateMessageDeliveryStatus(_ messageID: String, status: DeliveryStatus) {}
|
|
func didReceiveNoisePayload(from peerID: PeerID, type: NoisePayloadType, payload: Data, timestamp: Date) {}
|
|
func didUpdateBluetoothState(_ state: CBManagerState) {}
|
|
func didReceivePublicMessage(from peerID: PeerID, nickname: String, content: String, timestamp: Date) {
|
|
publicMessages.append((peerID, nickname, content))
|
|
}
|
|
func didReceiveRegionalPublicMessage(from peerID: PeerID, nickname: String, content: String, timestamp: Date) {}
|
|
}
|
|
|
|
// Helper: build a large message packet (unencrypted public message)
|
|
private func makeLargePublicPacket(senderShortHex: PeerID, size: Int) -> BitchatPacket {
|
|
let content = String(repeating: "A", count: size)
|
|
let payload = Data(content.utf8)
|
|
let pkt = BitchatPacket(
|
|
type: MessageType.message.rawValue,
|
|
senderID: Data(hexString: senderShortHex.id) ?? Data(),
|
|
recipientID: nil,
|
|
timestamp: UInt64(Date().timeIntervalSince1970 * 1000),
|
|
payload: payload,
|
|
signature: nil,
|
|
ttl: 7
|
|
)
|
|
return pkt
|
|
}
|
|
|
|
// Helper: fragment a packet using the same header format BLEService expects
|
|
private func fragmentPacket(_ packet: BitchatPacket, fragmentSize: Int, fragmentID: Data? = nil) -> [BitchatPacket] {
|
|
let fullData = packet.toBinaryData() ?? Data()
|
|
let fid = fragmentID ?? Data((0..<8).map { _ in UInt8.random(in: 0...255) })
|
|
let chunks: [Data] = stride(from: 0, to: fullData.count, by: fragmentSize).map { off in
|
|
Data(fullData[off..<min(off + fragmentSize, fullData.count)])
|
|
}
|
|
let total = UInt16(chunks.count)
|
|
var packets: [BitchatPacket] = []
|
|
for (i, chunk) in chunks.enumerated() {
|
|
var payload = Data()
|
|
payload.append(fid)
|
|
var idxBE = UInt16(i).bigEndian
|
|
var totBE = total.bigEndian
|
|
withUnsafeBytes(of: &idxBE) { payload.append(contentsOf: $0) }
|
|
withUnsafeBytes(of: &totBE) { payload.append(contentsOf: $0) }
|
|
payload.append(packet.type)
|
|
payload.append(chunk)
|
|
let fpkt = BitchatPacket(
|
|
type: MessageType.fragment.rawValue,
|
|
senderID: packet.senderID,
|
|
recipientID: packet.recipientID,
|
|
timestamp: packet.timestamp,
|
|
payload: payload,
|
|
signature: nil,
|
|
ttl: packet.ttl
|
|
)
|
|
packets.append(fpkt)
|
|
}
|
|
return packets
|
|
}
|
|
}
|