mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-07-25 19:25:20 +00:00
jackandIslam
4f62364bf4
CRITICAL BUG FIX: Spam filter was blocking Bluetooth mesh messages
PROBLEM
=======
SpamFilterService was being applied to ALL public messages including
local Bluetooth mesh messages. This caused legitimate back-and-forth
chat to be rate-limited and dropped.
Logs showed:
Rate limited message from mesh:... (sender:false content:true)
The sender token bucket (capacity: 5, refill: 1/sec) was exhausted
during normal conversation, blocking messages.
ROOT CAUSE
==========
When extracting SpamFilterService, the spam filter was applied to both:
- Geohash/Nostr messages (from internet - spam risk HIGH)
- Mesh/Bluetooth messages (local trusted peers - spam risk LOW)
Mesh messages should NOT be aggressively rate-limited since they come
from local trusted peers over Bluetooth.
SOLUTION
========
Changed spam filter to ONLY apply to geohash messages:
Before:
if !spamFilter.shouldAllow(message) { return }
After:
if isGeo && !spamFilter.shouldAllow(message) { return }
Now mesh messages bypass spam filter entirely, while geohash messages
from internet still get rate-limited protection.
IMPACT
======
✅ Mesh messages now flow freely (no artificial rate limiting)
✅ Geohash messages still protected from spam
✅ Normal back-and-forth chat works correctly
✅ Tests still passing
This fix is critical for usability - mesh chat is the core feature.