Files
bitchat/bitchatTests/VoiceBurstPacketTests.swift
eacd8f0750 Live push-to-talk voice for DMs (streams while you talk, voice note as fallback) (#1403)
* Live push-to-talk voice for DMs: stream while you talk, voice note as fallback

Holding the mic in a DM now streams AAC frames live over the Noise session
(walkie-talkie style, ~0.5s mouth-to-ear at one hop) while recording the same
audio as a normal voice note. On release the note ships through the existing
fileTransfer pipeline; receivers that heard the live stream absorb it silently
into the same bubble (matched by the burst ID embedded in the file name), so
reliability comes for free and nobody sees duplicates.

Protocol:
- NoisePayloadType.voiceFrame = 0x08 carrying VoiceBurstPacket
  (burstID + seq + START/data/END/CANCELED, length-prefixed AAC frames)
- 210-byte burst-content budget keeps each Noise packet inside the 256-byte
  padding bucket: one BLE frame, never the fragment scheduler
- fire-and-forget: frames are dropped (never queued) without an established
  session; live is only offered when the peer is mesh-reachable

Receive:
- ChatLiveVoiceCoordinator assembles bursts (jitter-ordered, 0.5s gap skip,
  3s idle end, flood/size caps), persists progressively as ADTS .aac so even
  a partial burst is a replayable bubble
- live autoplay only when the conversation is on screen, app active, and the
  new app-info "live voice messages" toggle is on (also gates live sending)
- one-playback-at-a-time via a shared ExclusivePlayback slot

Capture:
- PTTCaptureEngine taps AVAudioEngine, dual-encodes: live AAC frames + the
  finalized .m4a (same 16kHz/mono/16kbps settings as VoiceRecorder)
- VoiceRecordingViewModel now drives a pluggable VoiceCaptureSession; the
  composer HUD shows a pulsing LIVE treatment when streaming

Includes the push-to-talk design doc, 6 new localization keys across all 29
locales, and unit tests for framing, packetizer budget, ADTS output, codec
round-trip, and the assembly/absorb lifecycle. Public-mesh PTT (MessageType
0x29) lands separately on top of this.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* PTT follow-ups from review + field test: peer-ID normalization, toggle gates inbound, drop-path diagnostics

Codex review fixes (#1403):
- makeVoiceCaptureSession normalizes the selected peer with toShort() before
  the reachability/session checks and binds the send target to that same
  routing ID — a conversation selected under the stable 64-hex Noise key no
  longer silently falls back to a classic note while the short-ID session is
  established
- the live-voice toggle now gates inbound bursts too: off means
  classic-notes-only in both directions (no live bubble, partial file, or
  early notification; the finalized note still arrives), with a test

Field-test diagnostics (first device run: DM frames decrypted but no bubble
appeared, with no log evidence of which guard dropped them):
- coordinator logs undecodable frames (size + hex prefix) and blocked drops
- makeAssembly logs directory/file-handle failures instead of returning nil
  silently
- PTTLiveVoiceSession logs capture start and finish (packet/frame/duration
  counts); PTTCaptureEngine logs engine start success/failure with the input
  format; BLEService.sendVoiceFrame logs no-session drops

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Fix iPhone live-capture failure: dead input unit (AURemoteIO -10851, 0 Hz)

Field testing showed the phone's live capture failing at mic enable with
AURemoteIO -10851 and an input format of 0 Hz / 2 ch — an input unit bound
to an earlier (playback-only or settling) audio session. The Mac, which has
no session lifecycle, captured fine, which is why public bursts from the Mac
worked while phone-side sends degraded from working (first hold) to sporadic
to dead across holds.

Three layers of defense:
- PTTCaptureEngine recreates its AVAudioEngine on every start(), after the
  session is configured, so the input unit binds to the session that is
  active now; a dead input (0 Hz or 0 channels) is now a distinct, logged
  error instead of a silent setup failure
- PTTLiveVoiceSession retries the capture start once after a 150 ms
  route-settle pause
- VoiceRecordingViewModel falls back to the classic VoiceRecorder within the
  same hold if the live engine still cannot start — a route glitch now costs
  the live stream, never the voice note

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: jack <jackjackbits@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-08 09:20:58 +02:00

162 lines
6.3 KiB
Swift

//
// VoiceBurstPacketTests.swift
// bitchatTests
//
// This is free and unencumbered software released into the public domain.
// For more information, see <https://unlicense.org>
//
import Testing
import Foundation
@testable import bitchat
struct VoiceBurstPacketTests {
private let burstID = Data((0..<8).map { UInt8($0 + 1) })
// MARK: - Round trips
@Test func startRoundTrip() throws {
let packet = try #require(VoiceBurstPacket(burstID: burstID, seq: 0, kind: .start(codec: .aacLC16kMono)))
let decoded = try #require(VoiceBurstPacket.decode(packet.encode()))
#expect(decoded == packet)
#expect(decoded.seq == 0)
}
@Test func framesRoundTrip() throws {
let frames = [Data([0xDE, 0xAD]), Data(repeating: 0x42, count: 130)]
let packet = try #require(VoiceBurstPacket(burstID: burstID, seq: 7, kind: .frames(frames)))
let decoded = try #require(VoiceBurstPacket.decode(packet.encode()))
#expect(decoded == packet)
guard case .frames(let decodedFrames) = decoded.kind else {
Issue.record("expected frames")
return
}
#expect(decodedFrames == frames)
}
@Test func endRoundTrip() throws {
let packet = try #require(VoiceBurstPacket(burstID: burstID, seq: 42, kind: .end(totalDataPackets: 41, durationMs: 2_688)))
let decoded = try #require(VoiceBurstPacket.decode(packet.encode()))
#expect(decoded == packet)
}
@Test func canceledRoundTrip() throws {
let packet = try #require(VoiceBurstPacket(burstID: burstID, seq: 3, kind: .canceled))
let decoded = try #require(VoiceBurstPacket.decode(packet.encode()))
#expect(decoded == packet)
}
@Test func decodeSurvivesReslicedData() throws {
// Simulates the payload arriving as a slice with a non-zero start index.
let packet = try #require(VoiceBurstPacket(burstID: burstID, seq: 1, kind: .frames([Data([1, 2, 3])])))
var padded = Data([0xAA, 0xBB])
padded.append(packet.encode())
let slice = padded.dropFirst(2)
#expect(VoiceBurstPacket.decode(slice) == packet)
}
// MARK: - Validation
@Test func rejectsMalformedInput() {
#expect(VoiceBurstPacket.decode(Data()) == nil)
#expect(VoiceBurstPacket.decode(Data(repeating: 0, count: 10)) == nil)
// Unknown flags byte.
var unknownFlags = burstID
unknownFlags.append(contentsOf: [0, 1, 0xFF])
#expect(VoiceBurstPacket.decode(unknownFlags) == nil)
// Data packet with zero frames.
var empty = burstID
empty.append(contentsOf: [0, 1, 0])
#expect(VoiceBurstPacket.decode(empty) == nil)
// Truncated frame length.
var truncated = burstID
truncated.append(contentsOf: [0, 1, 0, 0x00, 0x10, 0xAB])
#expect(VoiceBurstPacket.decode(truncated) == nil)
// Unknown codec in START.
var badCodec = burstID
badCodec.append(contentsOf: [0, 0, 0x01, 0x7F])
#expect(VoiceBurstPacket.decode(badCodec) == nil)
}
@Test func rejectsInvalidConstruction() {
#expect(VoiceBurstPacket(burstID: Data([1, 2]), seq: 0, kind: .canceled) == nil)
#expect(VoiceBurstPacket(burstID: burstID, seq: 1, kind: .frames([])) == nil)
#expect(VoiceBurstPacket(burstID: burstID, seq: 1, kind: .frames([Data()])) == nil)
let tooMany = Array(repeating: Data([0x01]), count: VoiceBurstPacket.maxFramesPerPacket + 1)
#expect(VoiceBurstPacket(burstID: burstID, seq: 1, kind: .frames(tooMany)) == nil)
}
@Test func makeBurstIDProducesUniqueEightBytes() {
let a = VoiceBurstPacket.makeBurstID()
let b = VoiceBurstPacket.makeBurstID()
#expect(a.count == VoiceBurstPacket.burstIDSize)
#expect(a != b)
}
// MARK: - Packetizer
@Test func packetizerRespectsBudgetAndCounts() throws {
var packetizer = VoiceBurstPacketizer(burstID: burstID, budget: 210)
let frame = Data(repeating: 0x55, count: 130) // realistic 16 kbps AAC frame
// First frame buffers, second forces a flush of the first.
#expect(packetizer.add(frame).isEmpty)
let flushed = packetizer.add(frame)
#expect(flushed.count == 1)
let first = try #require(VoiceBurstPacket.decode(flushed[0]))
#expect(first.seq == 1)
guard case .frames(let frames) = first.kind else {
Issue.record("expected frames")
return
}
#expect(frames == [frame])
// Remaining frame flushes on demand; counters advance.
let final = packetizer.flush()
#expect(final.count == 1)
#expect(try #require(VoiceBurstPacket.decode(final[0])).seq == 2)
#expect(packetizer.dataPacketCount == 2)
#expect(packetizer.nextSeq == 3)
#expect(packetizer.flush().isEmpty)
}
@Test func packetizerBatchesSmallFrames() throws {
var packetizer = VoiceBurstPacketizer(burstID: burstID, budget: 210)
let small = Data(repeating: 0x11, count: 40)
for _ in 0..<4 {
#expect(packetizer.add(small).isEmpty) // 4 * 42 + 11 = 179 <= 210
}
let packets = packetizer.flush()
#expect(packets.count == 1)
guard case .frames(let frames) = try #require(VoiceBurstPacket.decode(packets[0])).kind else {
Issue.record("expected frames")
return
}
#expect(frames.count == 4)
}
@Test func packetizerDropsOversizedFrame() {
var packetizer = VoiceBurstPacketizer(burstID: burstID, budget: 210)
#expect(packetizer.add(Data(repeating: 0, count: 500)).isEmpty)
#expect(packetizer.flush().isEmpty)
#expect(packetizer.dataPacketCount == 0)
}
@Test func encodedPacketStaysWithinNoisePaddingBucket() throws {
// The whole point of the budget: burst content + 1 type byte +
// 16-byte Noise tag must stay within MessagePadding's 256 bucket.
var packetizer = VoiceBurstPacketizer(burstID: burstID)
var largest = 0
for _ in 0..<3 {
for packet in packetizer.add(Data(repeating: 0xAB, count: 160)) {
largest = max(largest, packet.count)
}
}
for packet in packetizer.flush() {
largest = max(largest, packet.count)
}
#expect(largest > 0)
#expect(largest + 1 + 16 <= 256)
}
}