Fix broke tests with LocationNotesManagerTests to expect localization key (#699)

* fix(test): update LocationNotesManagerTests to expect localization key

The tests were failing because in the test environment, String(localized:) returns
the localization key instead of the actual localized value. Updated the assertions
to expect 'location_notes.error.no_relays' instead of the English translation
'no geo relays available near this location. try again soon.'

* Fix LocationNotesManager test assertions for localization bundle

- Update test assertions to use String(localized:) to match manager behavior in test environment
- Fixes issue where tests expected localized text but manager returns raw keys in SPM test environment
- Both manager and tests now consistently handle localization bundle differences
- Resolves P1 issue: Keep LocationNotes error messages localized
- All 124 tests now pass after clean build

* SPM: process bitchat/Localizable.xcstrings in main target to fix CLI warning; keep tests' Localization resource.
This commit is contained in:
Jonathan Boice
2025-09-30 12:32:53 +02:00
committed by GitHub
parent b873b19104
commit f67f728d79
2 changed files with 3 additions and 3 deletions
+1 -1
View File
@@ -38,7 +38,7 @@ let package = Package(
"Services/Tor/C/"
],
resources: [
.process("Localization")
.process("Localizable.xcstrings")
],
linkerSettings: [
.linkedLibrary("z")