permissionlesstech/bitchat
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat.git synced 2026-07-27 11:45:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Delete shortTimeout now that nothing may use it

Browse Source 
The hygiene guard bans `TestConstants.shortTimeout` at every wait site
and the last users were converted, so Periphery correctly flagged the
constant itself as dead and failed CI. Remove it from both TestConstants
copies; the banned-name entry stays so the symbol cannot quietly return.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
jack
2026-07-26 23:32:17 +01:00
co-authored by Claude Fable 5
parent 2d58bbcfaf
commit f3280659ac
3 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bitchatTests/TestUtilities/TestConstants.swift
-1
View File
@@ -11,7 +11,6 @@ import Foundation
struct TestConstants { struct TestConstants {
static let defaultTimeout: TimeInterval = 5.0 static let defaultTimeout: TimeInterval = 5.0
static let shortTimeout: TimeInterval = 1.0
/// For positive waits on work that hops through `Task.detached` or /// For positive waits on work that hops through `Task.detached` or
/// background queues: those contend with every parallel test worker for /// background queues: those contend with every parallel test worker for
/// the global executor, so a loaded CI runner can exceed /// the global executor, so a loaded CI runner can exceed
bitchatTests/TestUtilities/TestTimingHygieneTests.swift
+2
View File
@@ -96,6 +96,8 @@ struct TestTimingHygieneTests {
// Named constants hide the same mistake behind a symbol, and did: the // Named constants hide the same mistake behind a symbol, and did: the
// fifth flake of the session was `timeout: TestConstants.shortTimeout` // fifth flake of the session was `timeout: TestConstants.shortTimeout`
// (1 s) on a positive wait, which a literals-only scan cannot see. // (1 s) on a positive wait, which a literals-only scan cannot see.
// `shortTimeout` itself is deleted (Periphery flagged it dead once its
// last wait site converted); the ban stays so it cannot come back.
// `negativeWaitWindow` is deliberately absent — short is correct there. // `negativeWaitWindow` is deliberately absent — short is correct there.
let bannedConstants = ["shortTimeout", "defaultTimeout"] let bannedConstants = ["shortTimeout", "defaultTimeout"]
localPackages/BitFoundation/Tests/BitFoundationTests/TestConstants.swift
-1
View File
@@ -11,7 +11,6 @@ import Foundation
// Kept local until the test-helper module is split out. // Kept local until the test-helper module is split out.
struct TestConstants { struct TestConstants {
static let defaultTimeout: TimeInterval = 5.0 static let defaultTimeout: TimeInterval = 5.0
static let shortTimeout: TimeInterval = 1.0
static let longTimeout: TimeInterval = 10.0 static let longTimeout: TimeInterval = 10.0
static let testNickname1 = "Alice" static let testNickname1 = "Alice"