permissionlesstech/bitchat
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat.git synced 2026-07-25 02:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent spoofable plaintext messages from sliding into private chats (#428)

Browse Source
This commit is contained in:
Alex Rad
2025-08-11 17:05:36 +02:00
committed by GitHub
parent d4262fab6c
commit c6c186c77b
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bitchat/Services/BluetoothMeshService.swift
+7 -2
View File
@@ -3374,7 +3374,7 @@ class BluetoothMeshService: NSObject {
} }
} }
private func handleReceivedPacket(_ packet: BitchatPacket, from peerID: String, peripheral: CBPeripheral? = nil) { private func handleReceivedPacket(_ packet: BitchatPacket, from peerID: String, peripheral: CBPeripheral? = nil, decrypted: Bool = false) {
messageQueue.async(flags: .barrier) { [weak self] in messageQueue.async(flags: .barrier) { [weak self] in
guard let self = self else { return } guard let self = self else { return }
@@ -3688,6 +3688,11 @@ class BluetoothMeshService: NSObject {
} else if isPeerIDOurs(recipientID.hexEncodedString()) { } else if isPeerIDOurs(recipientID.hexEncodedString()) {
// PRIVATE MESSAGE FOR US // PRIVATE MESSAGE FOR US
if (decrypted == false) {
//spoofing detected!!
SecureLogger.log("YIKES spoofing detected from \(senderID)", category: SecureLogger.encryption, level: .warning)
return;
}
// No signature verification - broadcasts are not authenticated // No signature verification - broadcasts are not authenticated
@@ -6888,7 +6893,7 @@ extension BluetoothMeshService: CBPeripheralManagerDelegate {
// The packet will be handled according to its recipient ID // The packet will be handled according to its recipient ID
// If it's for us, it won't be relayed // If it's for us, it won't be relayed
// Pass the peripheral context for proper ACK routing // Pass the peripheral context for proper ACK routing
handleReceivedPacket(innerPacket, from: peerID, peripheral: peripheral) handleReceivedPacket(innerPacket, from: peerID, peripheral: peripheral, decrypted: true)
} else { } else {
SecureLogger.log("Failed to parse inner packet from decrypted data", category: SecureLogger.encryption, level: .warning) SecureLogger.log("Failed to parse inner packet from decrypted data", category: SecureLogger.encryption, level: .warning)
} }