Fix ordinary Noise handshake races

2026-07-26 10:05:19 +00:00 · 2026-07-26 02:09:31 +02:00
parent 6e026c2c22
commit b255355fed
10 changed files with 1850 additions and 129 deletions
@@ -198,6 +198,24 @@ struct BLENoisePacketHandlerTests {
        #expect(recorder.broadcastPackets.isEmpty)
    }

+    @Test
+    func managedHandshakeFailureDoesNotStartASecondRecovery() {
+        let recorder = Recorder()
+        recorder.handshakeResult = .failure(
+            NoiseManagedHandshakeFailure(underlying: TestError())
+        )
+        recorder.hasSession = false
+        let handler = makeHandler(recorder: recorder)
+        let packet = makeHandshakePacket(
+            recipientID: Data(hexString: localPeerID.id)
+        )
+
+        #expect(!handler.handleHandshake(packet, from: remotePeerID))
+        #expect(recorder.hasSessionQueries.isEmpty)
+        #expect(recorder.initiatedHandshakes.isEmpty)
+        #expect(recorder.broadcastPackets.isEmpty)
+    }
+
    // MARK: Encrypted

    @Test