Refactor/ble nostr boundaries (#449)

* Refactor: move Nostr embedding and TLVs out of BLE; add NostrEmbeddedBitChat, Packets, PeerIDUtils; centralize MessageDeduplicator; update ChatViewModel to use new helpers; remove AI_CONTEXT.md and CLAUDE.md

* Rename class to BLEService with compatibility alias; move mention parsing out of BLE; emit low-level BLE events to delegate; unify hex helpers; accept 64-hex in isPeerConnected; add PeerIDResolver

* Project: rename file to BLEService.swift and update Xcode project; keep typealias SimplifiedBluetoothService = BLEService for compatibility

* Remove SimplifiedBluetoothService alias; update app code to use BLEService explicitly

* Tests: rename MockSimplifiedBluetoothService to MockBLEService; update typealiases and Xcode project

* Docs: update comments to refer to BLEService (tests, protocol, noise service)

* Tests: rename SimplifiedBluetoothServiceTests to BLEServiceTests; update project references and class names

* Introduce Transport protocol; BLEService conforms; document delegate-only event pattern in BLEService; keep publishers internal for UnifiedPeerService

* Adopt Transport end-to-end: add TransportPeerSnapshot + publishers; BLEService maps to Transport snapshots; UnifiedPeerService consumes Transport; ChatViewModel holds Transport

* Fix Transport integration: replace getPeerFingerprint with getFingerprint(for:); update PrivateChatManager and CommandProcessor to use Transport; add BLEService.getFingerprint(for:); update PeerManager to use Transport

* Refactor transport and BLE/Nostr layers; unify UI events; fix MainActor isolation

- Rename SimplifiedBluetoothService to BLEService and slim responsibilities
- Introduce Transport protocol and peerEventsDelegate for UI updates
- Add NostrTransport and MessageRouter to route PM/read/favorite via BLE or Nostr
- Centralize TLVs, PeerID utils, and MessageDeduplicator outside BLE
- Update UnifiedPeerService and ChatViewModel to use Transport and delegate events
- Fix MainActor isolation: route delegate calls via Task on MainActor; update notifyUI helper
- Adjust related files and tests accordingly

* BLEService: remove internal publishers; switch to delegate-only events

- Drop legacy messages/peers/fullPeers publishers
- Provide lightweight peerSnapshotSubject only to satisfy Transport
- Rework publishFullPeerData to build snapshots from internal state and notify delegate + subject
- Remove all peersPublisher.send call sites
- Keep UnifiedPeerService on delegate updates exclusively

* Remove inlined Nostr send helpers from ChatViewModel; route via MessageRouter

- Replace direct Nostr sends (PM, ACKs, favorites) with MessageRouter
- Add router method for delivery ACKs and implement NostrTransport.sendDeliveryAck
- Simplify ChatViewModel favorite notification path to use router
- Keep Nostr receive handling intact; reduce duplication

* Fix ReadReceipt initializer usage in ChatViewModel (readerID + readerNickname)

* Fix unused variable warning: replace shadowed 'nostrPubkey' bind with boolean check in ChatViewModel

* Fix queued PM format: use TLV for pending messages after Noise handshake

- Pending messages (including first-time favorite notifications) now use the same TLV encoding as normal sends
- Ensures ChatViewModel can decode on first send, even if handshake completes after queuing

---------

Co-authored-by: jack <jackjackbits@users.noreply.github.com>

bitchat/Services/Transport.swift

@@ -0,0 +1,57 @@
+import Foundation
+import Combine
+
+/// Abstract transport interface used by ChatViewModel and services.
+/// BLEService implements this protocol; a future Nostr transport can too.
+struct TransportPeerSnapshot {
+    let id: String
+    let nickname: String
+    let isConnected: Bool
+    let noisePublicKey: Data?
+    let lastSeen: Date
+}
+
+protocol Transport: AnyObject {
+    // Peer events (preferred over publishers for UI)
+    var peerEventsDelegate: TransportPeerEventsDelegate? { get set }
+    // Event sink
+    var delegate: BitchatDelegate? { get set }
+
+    // Identity
+    var myPeerID: String { get }
+    var myNickname: String { get }
+    func setNickname(_ nickname: String)
+
+    // Lifecycle
+    func startServices()
+    func stopServices()
+    func emergencyDisconnectAll()
+
+    // Connectivity and peers
+    func isPeerConnected(_ peerID: String) -> Bool
+    func getPeerNicknames() -> [String: String]
+
+    // Protocol utilities
+    func getFingerprint(for peerID: String) -> String?
+    func getNoiseSessionState(for peerID: String) -> LazyHandshakeState
+    func triggerHandshake(with peerID: String)
+    func getNoiseService() -> NoiseEncryptionService
+
+    // Messaging
+    func sendMessage(_ content: String, mentions: [String])
+    func sendPrivateMessage(_ content: String, to peerID: String, recipientNickname: String, messageID: String)
+    func sendReadReceipt(_ receipt: ReadReceipt, to peerID: String)
+    func sendFavoriteNotification(to peerID: String, isFavorite: Bool)
+    func sendBroadcastAnnounce()
+    func sendDeliveryAck(for messageID: String, to peerID: String)
+
+    // Peer snapshots (for non-UI services)
+    var peerSnapshotPublisher: AnyPublisher<[TransportPeerSnapshot], Never> { get }
+    func currentPeerSnapshots() -> [TransportPeerSnapshot]
+}
+
+protocol TransportPeerEventsDelegate: AnyObject {
+    @MainActor func didUpdatePeerSnapshots(_ peers: [TransportPeerSnapshot])
+}
+
+extension BLEService: Transport {}