Extract BLE and chat architecture policies (#1324)

Co-authored-by: jack <jackjackbits@users.noreply.github.com>
2026-07-25 12:45:20 +00:00 · 2026-06-02 09:01:59 +02:00
parent 193cfdc06a
commit 3eb4f2bd72
46 changed files with 3286 additions and 786 deletions
@@ -0,0 +1,143 @@
+import BitFoundation
+import Foundation
+import Testing
+@testable import bitchat
+
+struct BLEFileTransferPolicyTests {
+    @Test
+    func selfEchoRejectsOnlyNonSyncReplayFromLocalPeer() {
+        let localPeerID = PeerID(str: "1122334455667788")
+        let localPacket = makePacket(sender: localPeerID, ttl: 3)
+        let replayPacket = makePacket(sender: localPeerID, ttl: 0)
+        let remotePacket = makePacket(sender: PeerID(str: "8877665544332211"), ttl: 3)
+
+        #expect(BLEFileTransferPolicy.isSelfEcho(packet: localPacket, from: localPeerID, localPeerID: localPeerID))
+        #expect(!BLEFileTransferPolicy.isSelfEcho(packet: replayPacket, from: localPeerID, localPeerID: localPeerID))
+        #expect(!BLEFileTransferPolicy.isSelfEcho(packet: remotePacket, from: PeerID(str: "8877665544332211"), localPeerID: localPeerID))
+    }
+
+    @Test
+    func deliveryPlanTracksPublicBroadcastsForSync() {
+        let localPeerID = PeerID(str: "1122334455667788")
+
+        #expect(BLEFileTransferPolicy.deliveryPlan(
+            packet: makePacket(sender: PeerID(str: "8877665544332211"), recipientID: nil),
+            localPeerID: localPeerID
+        ) == BLEFileTransferDeliveryPlan(isPrivateMessage: false, shouldTrackForSync: true))
+
+        #expect(BLEFileTransferPolicy.deliveryPlan(
+            packet: makePacket(
+                sender: PeerID(str: "8877665544332211"),
+                recipientID: Data(repeating: 0xFF, count: 8)
+            ),
+            localPeerID: localPeerID
+        ) == BLEFileTransferDeliveryPlan(isPrivateMessage: false, shouldTrackForSync: true))
+    }
+
+    @Test
+    func deliveryPlanAcceptsOnlyDirectedPacketsForLocalPeer() {
+        let localPeerID = PeerID(str: "1122334455667788")
+        let otherPeerID = PeerID(str: "8877665544332211")
+
+        #expect(BLEFileTransferPolicy.deliveryPlan(
+            packet: makePacket(
+                sender: otherPeerID,
+                recipientID: Data(hexString: localPeerID.id)
+            ),
+            localPeerID: localPeerID
+        ) == BLEFileTransferDeliveryPlan(isPrivateMessage: true, shouldTrackForSync: false))
+
+        #expect(BLEFileTransferPolicy.deliveryPlan(
+            packet: makePacket(
+                sender: otherPeerID,
+                recipientID: Data(hexString: otherPeerID.id)
+            ),
+            localPeerID: localPeerID
+        ) == nil)
+    }
+
+    @Test
+    func validatorAcceptsMatchingMimeAndMagicBytes() throws {
+        let payload = try makeFilePayload(
+            mimeType: "application/pdf",
+            content: Data("%PDF-1.7".utf8)
+        )
+
+        let result = BLEIncomingFileValidator.validate(payload: payload)
+
+        guard case .success(let acceptance) = result else {
+            Issue.record("Expected file validation success")
+            return
+        }
+        #expect(acceptance.mime == .pdf)
+        #expect(acceptance.filePacket.content == Data("%PDF-1.7".utf8))
+    }
+
+    @Test
+    func validatorRejectsMalformedPayload() {
+        let result = BLEIncomingFileValidator.validate(payload: Data([0x01, 0x02, 0x03]))
+
+        #expect(result.rejection == .malformedPayload)
+    }
+
+    @Test
+    func validatorRejectsUnsupportedMime() throws {
+        let payload = try makeFilePayload(
+            mimeType: nil,
+            content: Data([0x4D, 0x5A, 0x00, 0x00])
+        )
+
+        let result = BLEIncomingFileValidator.validate(payload: payload)
+
+        #expect(result.rejection == .unsupportedMime(mimeType: nil, bytes: 4))
+    }
+
+    @Test
+    func validatorRejectsMimeMagicMismatch() throws {
+        let payload = try makeFilePayload(
+            mimeType: "image/png",
+            content: Data([0x00, 0x01, 0x02, 0x03])
+        )
+
+        let result = BLEIncomingFileValidator.validate(payload: payload)
+
+        #expect(result.rejection == .magicMismatch(
+            mime: .png,
+            bytes: 4,
+            prefixHex: "00 01 02 03"
+        ))
+    }
+
+    private func makePacket(
+        sender: PeerID,
+        ttl: UInt8 = 3,
+        recipientID: Data? = nil
+    ) -> BitchatPacket {
+        BitchatPacket(
+            type: MessageType.fileTransfer.rawValue,
+            senderID: Data(hexString: sender.id) ?? Data(),
+            recipientID: recipientID,
+            timestamp: 900_000,
+            payload: Data([0x01, 0x02]),
+            signature: nil,
+            ttl: ttl
+        )
+    }
+
+    private func makeFilePayload(mimeType: String?, content: Data) throws -> Data {
+        let packet = BitchatFilePacket(
+            fileName: "sample",
+            fileSize: UInt64(content.count),
+            mimeType: mimeType,
+            content: content
+        )
+        return try #require(packet.encode())
+    }
+}
+
+private extension Result where Failure == BLEIncomingFileRejection {
+    var rejection: BLEIncomingFileRejection? {
+        guard case .failure(let rejection) = self else { return nil }
+        return rejection
+    }
+}