permissionlesstech/bitchat
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat.git synced 2026-07-24 22:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resurrect dead Noise vector tests; add CI perf floors; make tests hermetic

Browse Source 
Package.swift's .process("Noise") resource claim silently excluded all
of bitchatTests/Noise/ from compilation since Oct 2025 - including a
complete official-vector runner (cacophony + snow XX transcripts,
transport messages, handshake hash, byte-identical to upstream).
Narrowing the resource to the JSON file and loading via Bundle.module
brings 51 Noise tests back to life, with a guard asserting each
vector's protocol name matches the app's.

CI gains a performance floor gate: perf-floors.json carries deliberately
generous floors (~25% of measured throughput) that catch algorithmic
regressions without flaking on runner variance; PERF lines reach the
gate via an O_APPEND side-channel file since swift test --parallel
swallows passing tests' stdout.

Tests are now hermetic: FavoritesPersistenceService uses an in-memory
keychain under test (fixes the securityd hang that blocked pipeline
benchmarks locally) and read-receipt persistence uses a wiped scratch
UserDefaults suite instead of .standard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
jack
2026-06-11 15:53:34 +02:00
co-authored by Claude Fable 5
parent 8a867a17a1
commit 22be3d6392
9 changed files with 285 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/swift-tests.yml
+14
View File
@@ -39,8 +39,22 @@ jobs:
${{ runner.os }}-${{ matrix.name }}-
- name: Run Tests
# BITCHAT_PERF_LOG captures the PERF[...] lines that
# PerformanceBaselineTests reports (swift test --parallel swallows
# stdout of passing tests, so the floor gate reads this file instead).
env:
BITCHAT_PERF_LOG: ${{ github.workspace }}/perf-output.log
run: swift test --parallel --quiet --enable-code-coverage --package-path ${{ matrix.path }}
# Order-of-magnitude performance regression gate (app tests only — the
# package matrix entries write no PERF lines and the gate would skip
# anyway). Floors are deliberately generous (~25% of healthy local
# throughput, see bitchatTests/Performance/perf-floors.json) so this
# catches algorithmic regressions, never runner variance.
- name: Performance floor gate
if: matrix.name == 'app'
run: ./scripts/check-perf-floors.sh perf-output.log
# Informational only: surfaces per-file and total line coverage in the
# job log so coverage trends are visible on every PR. No thresholds —
# this must never be the reason a build goes red.