permissionlesstech/bitchat
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat.git synced 2026-07-24 22:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct doc comment on signing-key pin recovery

Browse Source 
The comment on upsertCryptographicIdentity claimed a legitimately
re-keyed peer could recover via "explicit user re-verification", but no
such path exists: setVerified does not reset the signing-key pin. State
the actual recovery options — a new noise identity (new peerID) or
clearAllIdentityData.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
jack
2026-07-02 10:52:52 +02:00
co-authored by Claude Fable 5
parent c37e376568
commit 14ab04d2bb
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bitchat/Identity/SecureIdentityStateManager.swift
+5 -2
View File
@@ -347,8 +347,11 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
/// mirrors `BLEPeerRegistry.upsertVerifiedAnnounce` — without it, an /// mirrors `BLEPeerRegistry.upsertVerifiedAnnounce` — without it, an
/// attacker replaying a victim's noiseKey/peerID with their own signing /// attacker replaying a victim's noiseKey/peerID with their own signing
/// key could overwrite the victim's persisted identity while the victim is /// key could overwrite the victim's persisted identity while the victim is
/// offline or after an app restart. Recovering from a legitimate signing /// offline or after an app restart. The refusal is permanent: there is
/// re-key requires a new noise identity or explicit user re-verification. /// currently no targeted in-app way to reset the pin (`setVerified` does
/// not touch it). Recovering from a legitimate signing re-key requires the
/// peer to establish a new noise identity (new peerID) or the local user
/// to wipe all identity data (`clearAllIdentityData`, e.g. panic wipe).
/// - Parameters: /// - Parameters:
/// - fingerprint: SHA-256 hex of the Noise static public key /// - fingerprint: SHA-256 hex of the Noise static public key
/// - noisePublicKey: Noise static public key data /// - noisePublicKey: Noise static public key data