permissionlesstech/bitchat-android
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat-android.git synced 2026-07-24 22:45:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use CSPRNG for heartbeat intervals (#685)

Browse Source
This commit is contained in:
a1denvalu3
2026-03-25 14:42:53 +01:00
committed by GitHub
parent ce86f4ec2f
commit dac81b2c3b
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/com/bitchat/android/ui/GeohashViewModel.kt
+8 -3
View File
@@ -26,6 +26,8 @@ import java.util.Date
import kotlinx.coroutines.flow.collectLatest import kotlinx.coroutines.flow.collectLatest
import kotlinx.coroutines.isActive import kotlinx.coroutines.isActive
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers
import java.security.SecureRandom
import kotlin.random.asKotlinRandom
class GeohashViewModel( class GeohashViewModel(
application: Application, application: Application,
@@ -37,7 +39,10 @@ class GeohashViewModel(
private val notificationManager: NotificationManager private val notificationManager: NotificationManager
) : AndroidViewModel(application), DefaultLifecycleObserver { ) : AndroidViewModel(application), DefaultLifecycleObserver {
companion object { private const val TAG = "GeohashViewModel" } companion object {
private const val TAG = "GeohashViewModel"
private val secureRandom = SecureRandom().asKotlinRandom()
}
private val repo = GeohashRepository(application, state, dataManager) private val repo = GeohashRepository(application, state, dataManager)
private val subscriptionManager = NostrSubscriptionManager(application, viewModelScope) private val subscriptionManager = NostrSubscriptionManager(application, viewModelScope)
@@ -123,14 +128,14 @@ class GeohashViewModel(
// If channels change (e.g. user moves), collectLatest cancels this loop and starts a new one immediately // If channels change (e.g. user moves), collectLatest cancels this loop and starts a new one immediately
while (true) { while (true) {
// Randomize loop interval (40-80s, average 60s) // Randomize loop interval (40-80s, average 60s)
val loopInterval = kotlin.random.Random.nextLong(40000L, 80000L) val loopInterval = secureRandom.nextLong(40000L, 80000L)
var timeSpent = 0L var timeSpent = 0L
try { try {
Log.v(TAG, "💓 Broadcasting global presence to ${targetGeohashes.size} channels") Log.v(TAG, "💓 Broadcasting global presence to ${targetGeohashes.size} channels")
targetGeohashes.forEach { geohash -> targetGeohashes.forEach { geohash ->
// Decorrelate individual broadcasts with random delay (1s-5s) // Decorrelate individual broadcasts with random delay (1s-5s)
val stepDelay = kotlin.random.Random.nextLong(1000L, 10000L) val stepDelay = secureRandom.nextLong(1000L, 10000L)
delay(stepDelay) delay(stepDelay)
timeSpent += stepDelay timeSpent += stepDelay