Add active peer notification (#273)

* adding notification for active peers + tests * adding a recently seen peer set to track if we've seen that peer before * changing back to notificationManager naming * fixing some weird formatting that occurred during merge conflict fix
2026-07-25 11:45:19 +00:00 · 2025-08-28 09:17:41 +02:00
parent 28abd3c593
commit 02d5466812
6 changed files with 277 additions and 133 deletions
@@ -0,0 +1,110 @@
+package com.bitchat
+
+import android.content.Context
+import androidx.core.app.NotificationManagerCompat
+import androidx.test.core.app.ApplicationProvider
+import com.bitchat.android.ui.NotificationManager
+import com.bitchat.android.util.NotificationIntervalManager
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito
+import org.mockito.Mockito.times
+import org.mockito.MockitoAnnotations
+import org.mockito.Spy
+import org.mockito.kotlin.any
+import org.mockito.kotlin.never
+import org.mockito.kotlin.verify
+import org.robolectric.RobolectricTestRunner
+
+@RunWith(RobolectricTestRunner::class)
+class NotificationManagerTest {
+
+  private val context: Context = ApplicationProvider.getApplicationContext()
+  private val notificationIntervalManager = NotificationIntervalManager()
+  lateinit var notificationManager: NotificationManager
+
+  @Spy
+  val notificationManagerCompat: NotificationManagerCompat =
+    Mockito.spy(NotificationManagerCompat.from(context))
+
+  @Before
+  fun setup() {
+    MockitoAnnotations.openMocks(this)
+    notificationManager = NotificationManager(
+      context,
+      notificationManagerCompat,
+      notificationIntervalManager
+    )
+  }
+
+  @Test
+  fun `when there are no active peers, do not send active peer notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationManager.showActiveUserNotification(emptyList())
+    verify(notificationManagerCompat, never()).notify(any(), any())
+  }
+
+  @Test
+  fun `when app is in foreground, do not send active peer notification`() {
+    notificationManager.setAppBackgroundState(false)
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    verify(notificationManagerCompat, never()).notify(any(), any())
+  }
+
+  @Test
+  fun `when there is an active peer, send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    verify(notificationManagerCompat, times(1)).notify(any(), any())
+  }
+
+  @Test
+  fun `when there is an active peer but less than 5 minutes have passed since last notification, do not send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    notificationManager.showActiveUserNotification(listOf("peer-2"))
+    verify(notificationManagerCompat, times(1)).notify(any(), any())
+  }
+
+  @Test
+  fun `when there is an active peer and more than 5 minutes have passed since last notification, send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    notificationIntervalManager.setLastNetworkNotificationTime(System.currentTimeMillis() - 301_000L)
+    notificationManager.showActiveUserNotification(listOf("peer-2"))
+    verify(notificationManagerCompat, times(2)).notify(any(), any())
+  }
+
+  @Test
+  fun `when there is a recently seen peer but no new active peers, no notification is sent`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationIntervalManager.recentlySeenPeers.add("peer-1")
+    notificationManager.showActiveUserNotification(emptyList())
+    verify(notificationManagerCompat, times(0)).notify(any(), any())
+  }
+
+  @Test
+  fun `when an active peer is a recently seen peer, do not send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationIntervalManager.recentlySeenPeers.add("peer-1")
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    verify(notificationManagerCompat, times(0)).notify(any(), any())
+  }
+
+  @Test
+  fun `when an active peer is a new peer, send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationIntervalManager.recentlySeenPeers.addAll(emptyList())
+    notificationManager.showActiveUserNotification(listOf("peer-1"))
+    verify(notificationManagerCompat, times(1)).notify(any(), any())
+  }
+
+  @Test
+  fun `when an active peer is a new peer and there are already multiple recently seen peers, send notification`() {
+    notificationManager.setAppBackgroundState(true)
+    notificationIntervalManager.recentlySeenPeers.addAll(listOf("peer-1", "peer-2"))
+    notificationManager.showActiveUserNotification(listOf("peer-3"))
+    verify(notificationManagerCompat, times(1)).notify(any(), any())
+  }
+}